netdev - [PATCH net v3] r8152: add error handling in rtl8152_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251011082415.580740-1-yicongsrfy@163.com>
Date: Sat, 11 Oct 2025 16:24:15 +0800
From: yicongsrfy@....com
To: andrew+netdev@...n.ch,
	davem@...emloft.net,
	edumazet@...gle.com,
	oneukum@...e.com
Cc: horms@...nel.org,
	kuba@...nel.org,
	linux-usb@...r.kernel.org,
	netdev@...r.kernel.org,
	stable@...r.kernel.org,
	Yi Cong <yicong@...inos.cn>
Subject: [PATCH net v3] r8152: add error handling in rtl8152_driver_init

From: Yi Cong <yicong@...inos.cn>

rtl8152_driver_init missing error handling.
If cannot register rtl8152_driver, rtl8152_cfgselector_driver
should be deregistered.

Fixes: ec51fbd1b8a2 ("r8152: add USB device driver for config selection")
Cc: stable@...r.kernel.org
Signed-off-by: Yi Cong <yicong@...inos.cn>
Reviewed-by: Simon Horman <horms@...nel.org>

---
v2: replacing return 0 with return ret and adding Cc stable
v3: delete the redundant return ret
---
 drivers/net/usb/r8152.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 44cba7acfe7d..a22d4bb2cf3b 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -10122,7 +10122,12 @@ static int __init rtl8152_driver_init(void)
 	ret = usb_register_device_driver(&rtl8152_cfgselector_driver, THIS_MODULE);
 	if (ret)
 		return ret;
-	return usb_register(&rtl8152_driver);
+
+	ret = usb_register(&rtl8152_driver);
+	if (ret)
+		usb_deregister_device_driver(&rtl8152_cfgselector_driver);
+
+	return ret;
 }
 
 static void __exit rtl8152_driver_exit(void)
-- 
2.25.1