netdev - Re: [PATCH net-next] selftests: net: check jq command is supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61c106d9-6ea9-4ed4-ae01-267e6691e80b@huawei.com>
Date: Sat, 11 Oct 2025 11:26:08 +0800
From: Wang Liang <wangliang74@...wei.com>
To: Paolo Abeni <pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <yuehaibing@...wei.com>,
	<zhangchangzhong@...wei.com>
Subject: Re: [PATCH net-next] selftests: net: check jq command is supported


在 2025/10/10 22:56, Paolo Abeni 写道:
> On 10/10/25 5:30 AM, Wang Liang wrote:
>> The jq command is used in vlan_bridge_binding.sh, if it is not supported,
>> the test will spam the following log.
>>
>>    # ./vlan_bridge_binding.sh: line 51: jq: command not found
>>    # ./vlan_bridge_binding.sh: line 51: jq: command not found
>>    # ./vlan_bridge_binding.sh: line 51: jq: command not found
>>    # ./vlan_bridge_binding.sh: line 51: jq: command not found
>>    # ./vlan_bridge_binding.sh: line 51: jq: command not found
>>    # TEST: Test bridge_binding on->off when lower down                   [FAIL]
>>    #       Got operstate of , expected 0
>>
>> The rtnetlink.sh has the same problem. It makes sense to check if jq is
>> installed before running these tests. After this patch, the
>> vlan_bridge_binding.sh skipped if jq is not supported:
>>
>>    # timeout set to 3600
>>    # selftests: net: vlan_bridge_binding.sh
>>    # TEST: jq not installed                                              [SKIP]
>>
>> Signed-off-by: Wang Liang <wangliang74@...wei.com>
> This looks more a fix than net-next material (and net-next is currently
> closed for the merge window).
>
> Please re-post for net including suitable fixes tag(s). You can retain
> Hangbin's ack.
>
> Thanks,
>
> Paolo


Thanks for your reminder!

I missed the ANN e-mail when I was in Chinese National Day vacation. I will
repost this patch for net later.

------
Best regards
Wang Liang

>