netdev - Re: [PATCH net v2] r8169: fix packet truncation after S4 resume on RTL8168H/RTL8111H

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfd30b2b-efb4-4bde-8a10-fa07b3a88fab@intel.com>
Date: Mon, 13 Oct 2025 16:12:40 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Linmao Li <lilinmao@...inos.cn>,
	<netdev@...r.kernel.org>
CC: <pabeni@...hat.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>
Subject: Re: [PATCH net v2] r8169: fix packet truncation after S4 resume on
 RTL8168H/RTL8111H



On 10/12/2025 2:45 PM, Heiner Kallweit wrote:
> On 10/9/2025 2:25 PM, Linmao Li wrote:
>> After resume from S4 (hibernate), RTL8168H/RTL8111H truncates incoming
>> packets. Packet captures show messages like "IP truncated-ip - 146 bytes
>> missing!".
>>
>> The issue is caused by RxConfig not being properly re-initialized after
>> resume. Re-initializing the RxConfig register before the chip
>> re-initialization sequence avoids the truncation and restores correct
>> packet reception.
>>
> Seems to be some chip quirk, as the RxConfig register is re-initialized,
> just after the hw reset.
> 
>> This follows the same pattern as commit ef9da46ddef0 ("r8169: fix data
>> corruption issue on RTL8402").
>>
> I wonder whether more chip versions are affected.
> 
> What we can do: Apply this as fix for RTL_GIGA_MAC_VER_46 in net.
> Then switch to unconditionally calling rtl_init_rxcfg() in net-next.
> 

I had the same comment. I think this is a reasonable path as well.

Thanks,
Jake


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)