netdev - Re: [net,PATCH] net: phy: realtek: Avoid PHYCR2 access if PHYCR2 not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aOzyJuegXDTNCire@shell.armlinux.org.uk>
Date: Mon, 13 Oct 2025 13:35:50 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Marek Vasut <marek.vasut@...lbox.org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>, Daniel Golle <daniel@...rotopia.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Markus Stockhausen <markus.stockhausen@....de>,
	Michael Klein <michael@...sekall.de>,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [net,PATCH] net: phy: realtek: Avoid PHYCR2 access if PHYCR2 not
 present

On Sat, Oct 11, 2025 at 01:02:49PM +0200, Marek Vasut wrote:
> The driver is currently checking for PHYCR2 register presence in
> rtl8211f_config_init(), but it does so after accessing PHYCR2 to
> disable EEE. This was introduced in commit bfc17c165835 ("net:
> phy: realtek: disable PHY-mode EEE"). Move the PHYCR2 presence
> test before the EEE disablement and simplify the code.
> 
> Fixes: bfc17c165835 ("net: phy: realtek: disable PHY-mode EEE")
> Signed-off-by: Marek Vasut <marek.vasut@...lbox.org>

This looks obvious.

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Daniel Golle <daniel@...rotopia.org>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Heiner Kallweit <hkallweit1@...il.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Markus Stockhausen <markus.stockhausen@....de>
> Cc: Michael Klein <michael@...sekall.de>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Russell King <linux@...linux.org.uk>

Please drop this line.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!