netdev - Re: [PATCH v3 net-next] net/hsr: add protocol version to fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b25a73bf-1309-4f9f-9cd7-795e0615635b@suse.de>
Date: Tue, 14 Oct 2025 10:48:44 +0200
From: Fernando Fernandez Mancera <fmancera@...e.de>
To: Jan Vaclav <jvaclav@...hat.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>,
 Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next] net/hsr: add protocol version to fill_info
 output

On 10/9/25 11:09 PM, Jan Vaclav wrote:
> Currently, it is possible to configure IFLA_HSR_VERSION, but
> there is no way to check in userspace what the currently
> configured HSR protocol version is.
> 
> Add it to the output of hsr_fill_info(), when the interface
> is using the HSR protocol. Let's not expose it when using
> the PRP protocol, since it only has one version and it's
> not possible to set it from userspace.
> 
> This info could then be used by e.g. ip(8), like so:
> $ ip -d link show hsr0
> 12: hsr0: <BROADCAST,MULTICAST> mtu ...
>      ...
>      hsr slave1 veth0 slave2 veth1 ... proto 0 version 1

I think this is missing the 'Signed-off-by' tag. Other than that, it 
looks good to me. Not sure if it can be added while merging.

Reviewed-by: Fernando Fernandez Mancera <fmancera@...e.de>