netdev - Re: [PATCH net-next] net: bcmgenet: remove unused platform code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f6c4433-21dd-4ddd-8db2-4a45cf233941@broadcom.com>
Date: Tue, 14 Oct 2025 10:00:14 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Simon Horman <horms@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>
Cc: Doug Berger <opendmb@...il.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 David Miller <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: bcmgenet: remove unused platform code

On 10/14/25 06:13, Simon Horman wrote:
> On Tue, Oct 14, 2025 at 08:02:47AM +0200, Heiner Kallweit wrote:
>> This effectively reverts b0ba512e25d7 ("net: bcmgenet: enable driver to
>> work without a device tree"). There has never been an in-tree user of
>> struct bcmgenet_platform_data, all devices use OF or ACPI.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 
> I'm actually kind of surprised platform driver support was added as
> recently as 2014. But I guess there was a reason at the time.

Upstreaming of that driver was done in 2014 and as a result there was 
interest from a customer at a time to continue to work with the modern 
driver from upstream copied nearly as-is into the vendor tree, hence 
support for platform data was submitted and accepted to facilitate that.

Since said platforms are now supported by the BMIPS_GENERIC platform, 
which is DT only, it makes sense to remove the platform data code now.

Thanks!
-- 
Florian