netdev - Re: [PATCH net-next v6 1/5] eea: introduce PCI framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO-VhWosxJ8OnG_K@horms.kernel.org>
Date: Wed, 15 Oct 2025 13:37:25 +0100
From: Simon Horman <horms@...nel.org>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Wen Gu <guwen@...ux.alibaba.com>,
	Philo Lu <lulie@...ux.alibaba.com>,
	Lorenzo Bianconi <lorenzo@...nel.org>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Lukas Bulwahn <lukas.bulwahn@...hat.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Vivian Wang <wangruikang@...as.ac.cn>,
	Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
	Dust Li <dust.li@...ux.alibaba.com>
Subject: Re: [PATCH net-next v6 1/5] eea: introduce PCI framework

On Wed, Oct 15, 2025 at 03:11:41PM +0800, Xuan Zhuo wrote:

...

> diff --git a/drivers/net/ethernet/alibaba/eea/eea_pci.c b/drivers/net/ethernet/alibaba/eea/eea_pci.c

...

Hi,

This isn't a full review, but in this function edev is initialised
but otherwise unused. I suggest either using it or removing it.

Likewise in eea_pci_remove().

Flagged by W=1 builds.

> +
> +	err = eea_pci_setup(pci_dev, ep_dev);
> +	if (err)
> +		goto err_setup;
> +
> +	err = eea_init_device(&ep_dev->edev);
> +	if (err)
> +		goto err_register;
> +
> +	return 0;
> +
> +err_register:
> +	eea_pci_release_resource(ep_dev);
> +
> +err_setup:
> +	kfree(ep_dev);
> +	return err;
> +}

...

> +static void eea_pci_remove(struct pci_dev *pci_dev)
> +{
> +	struct eea_pci_device *ep_dev = pci_get_drvdata(pci_dev);
> +	struct eea_device *edev;
> +
> +	edev = &ep_dev->edev;
> +
> +	__eea_pci_remove(pci_dev, true);
> +
> +	kfree(ep_dev);
> +}

...