netdev - Re: [net-next v8 3/3] net: bonding: send peer notify when failure recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3BB6FFF9-7987-4FB0-B98F-B423C1A77B09@bamaicloud.com>
Date: Wed, 15 Oct 2025 21:29:03 +0800
From: Tonghao Zhang <tonghao@...aicloud.com>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org,
 Jay Vosburgh <jv@...sburgh.net>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 Steven Rostedt <rostedt@...dmis.org>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Nikolay Aleksandrov <razor@...ckwall.org>,
 Zengbing Tu <tuzengbing@...iglobal.com>,
 Antoine Tenart <atenart@...nel.org>
Subject: Re: [net-next v8 3/3] net: bonding: send peer notify when failure
 recovery

> On Oct 15, 2025, at 11:36, Hangbin Liu <liuhangbin@...il.com> wrote:
> 
> On Fri, Jun 27, 2025 at 09:49:30PM +0800, Tonghao Zhang wrote:
>> +static void ad_cond_set_peer_notif(struct port *port)
>> +{
>> + struct bonding *bond = port->slave->bond;
>> +
>> + if (bond->params.broadcast_neighbor && rtnl_trylock()) {
> 
> Hi Tonghao,
> 
> When do our internal review, Antoine pointed that this rtnl_trylock() may
> fail and cause the notify not send. The other places of bonding using
> workqueues to reschedule when the rtnl_trylock() failed. Do you think
> if we should also do some similar thing to avoid notify failed?
This is indeed a good optimization. I will submit the patch later.
> 
> Thanks
> Hangbin
>> + bond->send_peer_notif = bond->params.num_peer_notif *
>> + max(1, bond->params.peer_notif_delay);
>> + rtnl_unlock();
>> + }
>> +}
> 
>