| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251015140140.62273-2-daniel@iogearbox.net>
Date: Wed, 15 Oct 2025 16:01:26 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: netdev@...r.kernel.org
Cc: bpf@...r.kernel.org,
kuba@...nel.org,
davem@...emloft.net,
razor@...ckwall.org,
pabeni@...hat.com,
willemb@...gle.com,
sdf@...ichev.me,
john.fastabend@...il.com,
martin.lau@...nel.org,
jordan@...fe.io,
maciej.fijalkowski@...el.com,
magnus.karlsson@...el.com,
dw@...idwei.uk,
toke@...hat.com,
yangzhenze@...edance.com,
wangdongdong.6@...edance.com
Subject: [PATCH net-next v2 01/15] net: Add bind-queue operation
From: David Wei <dw@...idwei.uk>
Add a ynl netdev family operation called bind-queue that creates a new
rx queue in a virtual netdev (i.e. netkit or veth) and binds it to an rx
queue in a real netdev. This forms a queue pair, where the peer queue of
the pair in the virtual netdev acts as a proxy for the peer queue in the
real netdev. Thus, the peer queue in the virtual netdev can be used by
processes running in a container to use both memory providers (io_uring
zero-copy rx and devmem) and AF_XDP. An early implementation had only
driver-specific integration [0], but in order for other virtual devices
to reuse, it makes sense to have this as a generic API.
src-ifindex and src-queue-id is the real netdev and its rx queue id
respectively. dst-ifindex is the virtual netdev. Note that this op doesn't
take dst-queue-id because a new rx queue is created. The virtual netdev
must have real_num_rx_queues less than num_rx_queues at the time of
calling bind-queue. The queue-type must be rx as only rx queues are
supported for now.
Signed-off-by: David Wei <dw@...idwei.uk>
Co-developed-by: Daniel Borkmann <daniel@...earbox.net>
Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
Link: https://bpfconf.ebpf.io/bpfconf2025/bpfconf2025_material/lsfmmbpf_2025_netkit_borkmann.pdf [0]
---
Documentation/netlink/specs/netdev.yaml | 60 +++++++++++++++++++++++++
include/uapi/linux/netdev.h | 12 +++++
net/core/netdev-genl-gen.c | 25 +++++++++++
net/core/netdev-genl-gen.h | 1 +
net/core/netdev-genl.c | 5 +++
tools/include/uapi/linux/netdev.h | 12 +++++
6 files changed, 115 insertions(+)
diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
index e00d3fa1c152..20bb00b7e9ac 100644
--- a/Documentation/netlink/specs/netdev.yaml
+++ b/Documentation/netlink/specs/netdev.yaml
@@ -561,6 +561,46 @@ attribute-sets:
type: u32
checks:
min: 1
+ -
+ name: queue-pair
+ attributes:
+ -
+ name: queue-type
+ doc: |
+ Queue type as rx, tx, for src-queue-id and dst-queue-id.
+ Currently only pairing queues of type rx is supported.
+ type: u32
+ enum: queue-type
+ -
+ name: src-ifindex
+ doc: |
+ Specifies the netdev ifindex of the physical device to pair
+ src-queue-id from.
+ type: u32
+ checks:
+ min: 1
+ max: s32-max
+ -
+ name: src-queue-id
+ doc: |
+ Specifies the netdev queue id of the physical device with
+ src-ifindex to pair a queue from.
+ type: u32
+ -
+ name: dst-ifindex
+ doc: |
+ Specifies the netdev ifindex of the virtual device to pair
+ a new queue with the src-queue-id from src-ifindex.
+ type: u32
+ checks:
+ min: 1
+ max: s32-max
+ -
+ name: dst-queue-id
+ doc: |
+ Specifies the new netdev queue id of the virtual device after
+ a successful pairing operation.
+ type: u32
operations:
list:
@@ -772,6 +812,26 @@ operations:
attributes:
- id
+ -
+ name: bind-queue
+ doc: |
+ Bind a physical netdevice queue to a virtual one. The binding
+ creates a queue pair, where a queue can reference its peer queue.
+ This is useful for memory providers and AF_XDP operations which
+ take an ifindex and queue id to allow auch applications to bind
+ against virtual devices in containers.
+ attribute-set: queue-pair
+ do:
+ request:
+ attributes:
+ - queue-type
+ - src-ifindex
+ - src-queue-id
+ - dst-ifindex
+ reply:
+ attributes:
+ - dst-queue-id
+
kernel-family:
headers: ["net/netdev_netlink.h"]
sock-priv: struct netdev_nl_sock
diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h
index 48eb49aa03d4..4ef04d0bc412 100644
--- a/include/uapi/linux/netdev.h
+++ b/include/uapi/linux/netdev.h
@@ -210,6 +210,17 @@ enum {
NETDEV_A_DMABUF_MAX = (__NETDEV_A_DMABUF_MAX - 1)
};
+enum {
+ NETDEV_A_QUEUE_PAIR_QUEUE_TYPE = 1,
+ NETDEV_A_QUEUE_PAIR_SRC_IFINDEX,
+ NETDEV_A_QUEUE_PAIR_SRC_QUEUE_ID,
+ NETDEV_A_QUEUE_PAIR_DST_IFINDEX,
+ NETDEV_A_QUEUE_PAIR_DST_QUEUE_ID,
+
+ __NETDEV_A_QUEUE_PAIR_MAX,
+ NETDEV_A_QUEUE_PAIR_MAX = (__NETDEV_A_QUEUE_PAIR_MAX - 1)
+};
+
enum {
NETDEV_CMD_DEV_GET = 1,
NETDEV_CMD_DEV_ADD_NTF,
@@ -226,6 +237,7 @@ enum {
NETDEV_CMD_BIND_RX,
NETDEV_CMD_NAPI_SET,
NETDEV_CMD_BIND_TX,
+ NETDEV_CMD_BIND_QUEUE,
__NETDEV_CMD_MAX,
NETDEV_CMD_MAX = (__NETDEV_CMD_MAX - 1)
diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c
index e9a2a6f26cb7..69f8126c3e42 100644
--- a/net/core/netdev-genl-gen.c
+++ b/net/core/netdev-genl-gen.c
@@ -26,6 +26,16 @@ static const struct netlink_range_validation netdev_a_napi_defer_hard_irqs_range
.max = S32_MAX,
};
+static const struct netlink_range_validation netdev_a_queue_pair_src_ifindex_range = {
+ .min = 1ULL,
+ .max = S32_MAX,
+};
+
+static const struct netlink_range_validation netdev_a_queue_pair_dst_ifindex_range = {
+ .min = 1ULL,
+ .max = S32_MAX,
+};
+
/* Common nested types */
const struct nla_policy netdev_page_pool_info_nl_policy[NETDEV_A_PAGE_POOL_IFINDEX + 1] = {
[NETDEV_A_PAGE_POOL_ID] = NLA_POLICY_FULL_RANGE(NLA_UINT, &netdev_a_page_pool_id_range),
@@ -106,6 +116,14 @@ static const struct nla_policy netdev_bind_tx_nl_policy[NETDEV_A_DMABUF_FD + 1]
[NETDEV_A_DMABUF_FD] = { .type = NLA_U32, },
};
+/* NETDEV_CMD_BIND_QUEUE - do */
+static const struct nla_policy netdev_bind_queue_nl_policy[NETDEV_A_QUEUE_PAIR_DST_IFINDEX + 1] = {
+ [NETDEV_A_QUEUE_PAIR_QUEUE_TYPE] = NLA_POLICY_MAX(NLA_U32, 1),
+ [NETDEV_A_QUEUE_PAIR_SRC_IFINDEX] = NLA_POLICY_FULL_RANGE(NLA_U32, &netdev_a_queue_pair_src_ifindex_range),
+ [NETDEV_A_QUEUE_PAIR_SRC_QUEUE_ID] = { .type = NLA_U32, },
+ [NETDEV_A_QUEUE_PAIR_DST_IFINDEX] = NLA_POLICY_FULL_RANGE(NLA_U32, &netdev_a_queue_pair_dst_ifindex_range),
+};
+
/* Ops table for netdev */
static const struct genl_split_ops netdev_nl_ops[] = {
{
@@ -204,6 +222,13 @@ static const struct genl_split_ops netdev_nl_ops[] = {
.maxattr = NETDEV_A_DMABUF_FD,
.flags = GENL_CMD_CAP_DO,
},
+ {
+ .cmd = NETDEV_CMD_BIND_QUEUE,
+ .doit = netdev_nl_bind_queue_doit,
+ .policy = netdev_bind_queue_nl_policy,
+ .maxattr = NETDEV_A_QUEUE_PAIR_DST_IFINDEX,
+ .flags = GENL_CMD_CAP_DO,
+ },
};
static const struct genl_multicast_group netdev_nl_mcgrps[] = {
diff --git a/net/core/netdev-genl-gen.h b/net/core/netdev-genl-gen.h
index cf3fad74511f..309248fe2b9e 100644
--- a/net/core/netdev-genl-gen.h
+++ b/net/core/netdev-genl-gen.h
@@ -35,6 +35,7 @@ int netdev_nl_qstats_get_dumpit(struct sk_buff *skb,
int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info);
int netdev_nl_napi_set_doit(struct sk_buff *skb, struct genl_info *info);
int netdev_nl_bind_tx_doit(struct sk_buff *skb, struct genl_info *info);
+int netdev_nl_bind_queue_doit(struct sk_buff *skb, struct genl_info *info);
enum {
NETDEV_NLGRP_MGMT,
diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
index 470fabbeacd9..ce1018ea390f 100644
--- a/net/core/netdev-genl.c
+++ b/net/core/netdev-genl.c
@@ -1120,6 +1120,11 @@ int netdev_nl_bind_tx_doit(struct sk_buff *skb, struct genl_info *info)
return err;
}
+int netdev_nl_bind_queue_doit(struct sk_buff *skb, struct genl_info *info)
+{
+ return -EOPNOTSUPP;
+}
+
void netdev_nl_sock_priv_init(struct netdev_nl_sock *priv)
{
INIT_LIST_HEAD(&priv->bindings);
diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/netdev.h
index 48eb49aa03d4..4ef04d0bc412 100644
--- a/tools/include/uapi/linux/netdev.h
+++ b/tools/include/uapi/linux/netdev.h
@@ -210,6 +210,17 @@ enum {
NETDEV_A_DMABUF_MAX = (__NETDEV_A_DMABUF_MAX - 1)
};
+enum {
+ NETDEV_A_QUEUE_PAIR_QUEUE_TYPE = 1,
+ NETDEV_A_QUEUE_PAIR_SRC_IFINDEX,
+ NETDEV_A_QUEUE_PAIR_SRC_QUEUE_ID,
+ NETDEV_A_QUEUE_PAIR_DST_IFINDEX,
+ NETDEV_A_QUEUE_PAIR_DST_QUEUE_ID,
+
+ __NETDEV_A_QUEUE_PAIR_MAX,
+ NETDEV_A_QUEUE_PAIR_MAX = (__NETDEV_A_QUEUE_PAIR_MAX - 1)
+};
+
enum {
NETDEV_CMD_DEV_GET = 1,
NETDEV_CMD_DEV_ADD_NTF,
@@ -226,6 +237,7 @@ enum {
NETDEV_CMD_BIND_RX,
NETDEV_CMD_NAPI_SET,
NETDEV_CMD_BIND_TX,
+ NETDEV_CMD_BIND_QUEUE,
__NETDEV_CMD_MAX,
NETDEV_CMD_MAX = (__NETDEV_CMD_MAX - 1)
--
2.43.0
Powered by blists - more mailing lists