netdev - Re: [PATCH net-next v2] net: amd-xgbe: use EOPNOTSUPP instead of ENOTSUPP in xgbe_phy_mii_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7855fb73-6fab-40e4-8ad7-75f6223a00b9@amd.com>
Date: Wed, 15 Oct 2025 09:42:41 +0530
From: Shyam Sundar S K <Shyam-sundar.S-k@....com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, kuba@...nel.org,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org, linux@...linux.org.uk,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: amd-xgbe: use EOPNOTSUPP instead of
 ENOTSUPP in xgbe_phy_mii_read_c45



On 10/15/2025 08:27, Alok Tiwari wrote:
> The MDIO read callback xgbe_phy_mii_read_c45() can propagate its return
> value up through phylink_mii_ioctl() to user space via netdev ioctls such
> as SIOCGMIIREG. Returning ENOTSUPP results in user space seeing
> "Unknown error", since ENOTSUPP is not a standard errno value.
> 
> Replace ENOTSUPP with EOPNOTSUPP to align with the MDIO core’s
> usage and ensure user space receives a proper "Operation not supported"
> error instead of an unknown code.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Looks good to me.

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>

Thanks,
Shyam