netdev - Re: [PATCH 01/15] arm64: dts: mediatek: mt7981b: Add labels to commonly referenced nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6f96421-523b-4236-a5f8-c28ffd1c2d4c@collabora.com>
Date: Thu, 16 Oct 2025 13:29:25 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Sjoerd Simons <sjoerd@...labora.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Ryder Lee <ryder.lee@...iatek.com>, Jianjun Wang
 <jianjun.wang@...iatek.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>,
 Chunfeng Yun <chunfeng.yun@...iatek.com>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>, Lee Jones <lee@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Felix Fietkau <nbd@....name>
Cc: kernel@...labora.com, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-pci@...r.kernel.org,
 linux-phy@...ts.infradead.org, netdev@...r.kernel.org,
 Daniel Golle <daniel@...rotopia.org>, Bryan Hinton <bryan@...anhinton.com>
Subject: Re: [PATCH 01/15] arm64: dts: mediatek: mt7981b: Add labels to
 commonly referenced nodes

Il 16/10/25 12:08, Sjoerd Simons ha scritto:
> Add labels to various device nodes in the MT7981B DTSI, similar to other
> mediatek dtsi files.
> 
> Signed-off-by: Sjoerd Simons <sjoerd@...labora.com>

If you're not using the labels, it makes no sense to have them.

Please add them in the same commit(s) in which you actually assign phandles to the
nodes that need labels.

Cheers,
Angelo

> ---
>   arch/arm64/boot/dts/mediatek/mt7981b.dtsi | 24 ++++++++++++------------
>   1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> index 58c99f2a25218..6b024156fa7c5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> @@ -14,14 +14,14 @@ cpus {
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>   
> -		cpu@0 {
> +		cpu0: cpu@0 {
>   			compatible = "arm,cortex-a53";
>   			reg = <0x0>;
>   			device_type = "cpu";
>   			enable-method = "psci";
>   		};
>   
> -		cpu@1 {
> +		cpu1: cpu@1 {
>   			compatible = "arm,cortex-a53";
>   			reg = <0x1>;
>   			device_type = "cpu";
> @@ -29,7 +29,7 @@ cpu@1 {
>   		};
>   	};
>   
> -	oscillator-40m {
> +	clk40m: oscillator-40m {
>   		compatible = "fixed-clock";
>   		clock-frequency = <40000000>;
>   		clock-output-names = "clkxtal";
> @@ -82,7 +82,7 @@ apmixedsys: clock-controller@...1e000 {
>   			#clock-cells = <1>;
>   		};
>   
> -		pwm@...48000 {
> +		pwm: pwm@...48000 {
>   			compatible = "mediatek,mt7981-pwm";
>   			reg = <0 0x10048000 0 0x1000>;
>   			clocks = <&infracfg CLK_INFRA_PWM_STA>,
> @@ -127,7 +127,7 @@ uart2: serial@...04000 {
>   			status = "disabled";
>   		};
>   
> -		i2c@...07000 {
> +		i2c0: i2c@...07000 {
>   			compatible = "mediatek,mt7981-i2c";
>   			reg = <0 0x11007000 0 0x1000>,
>   			      <0 0x10217080 0 0x80>;
> @@ -142,7 +142,7 @@ i2c@...07000 {
>   			status = "disabled";
>   		};
>   
> -		spi@...09000 {
> +		spi2: spi@...09000 {
>   			compatible = "mediatek,mt7981-spi-ipm", "mediatek,spi-ipm";
>   			reg = <0 0x11009000 0 0x1000>;
>   			interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
> @@ -156,7 +156,7 @@ spi@...09000 {
>   			status = "disabled";
>   		};
>   
> -		spi@...0a000 {
> +		spi0: spi@...0a000 {
>   			compatible = "mediatek,mt7981-spi-ipm", "mediatek,spi-ipm";
>   			reg = <0 0x1100a000 0 0x1000>;
>   			interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
> @@ -170,7 +170,7 @@ spi@...0a000 {
>   			status = "disabled";
>   		};
>   
> -		spi@...0b000 {
> +		spi1: spi@...0b000 {
>   			compatible = "mediatek,mt7981-spi-ipm", "mediatek,spi-ipm";
>   			reg = <0 0x1100b000 0 0x1000>;
>   			interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> @@ -184,7 +184,7 @@ spi@...0b000 {
>   			status = "disabled";
>   		};
>   
> -		thermal@...0c800 {
> +		thermal: thermal@...0c800 {
>   			compatible = "mediatek,mt7981-thermal",
>   				     "mediatek,mt7986-thermal";
>   			reg = <0 0x1100c800 0 0x800>;
> @@ -231,7 +231,7 @@ pio: pinctrl@...00000 {
>   			#interrupt-cells = <2>;
>   		};
>   
> -		efuse@...20000 {
> +		efuse: efuse@...20000 {
>   			compatible = "mediatek,mt7981-efuse", "mediatek,efuse";
>   			reg = <0 0x11f20000 0 0x1000>;
>   			#address-cells = <1>;
> @@ -246,14 +246,14 @@ thermal_calibration: thermal-calib@274 {
>   			};
>   		};
>   
> -		clock-controller@...00000 {
> +		ethsys: clock-controller@...00000 {
>   			compatible = "mediatek,mt7981-ethsys", "syscon";
>   			reg = <0 0x15000000 0 0x1000>;
>   			#clock-cells = <1>;
>   			#reset-cells = <1>;
>   		};
>   
> -		wifi@...00000 {
> +		wifi: wifi@...00000 {
>   			compatible = "mediatek,mt7981-wmac";
>   			reg = <0 0x18000000 0 0x1000000>,
>   			      <0 0x10003000 0 0x1000>,
>