netdev - Re: [PATCH net-next v6 5/5] eea: introduce ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1760584372.6252325-1-xuanzhuo@linux.alibaba.com>
Date: Thu, 16 Oct 2025 11:12:52 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org,
 Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Wen Gu <guwen@...ux.alibaba.com>,
 Philo Lu <lulie@...ux.alibaba.com>,
 Lorenzo Bianconi <lorenzo@...nel.org>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Lukas Bulwahn <lukas.bulwahn@...hat.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Vivian Wang <wangruikang@...as.ac.cn>,
 Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
 Dust Li <dust.li@...ux.alibaba.com>
Subject: Re: [PATCH net-next v6 5/5] eea: introduce ethtool support

On Wed, 15 Oct 2025 21:58:07 +0200, Andrew Lunn <andrew@...n.ch> wrote:
> > @@ -111,6 +116,8 @@ struct eea_net_cfg {
> >  	u8 tx_cq_desc_size;
> >
> >  	u32 split_hdr;
> > +
> > +	struct hwtstamp_config ts_cfg;
> >  };
> >
>
> > @@ -391,6 +397,10 @@ static void eea_submit_skb(struct eea_net_rx *rx, struct sk_buff *skb,
> >  	if (rx->pkt.data_valid)
> >  		skb->ip_summed = CHECKSUM_UNNECESSARY;
> >
> > +	if (enet->cfg.ts_cfg.rx_filter == HWTSTAMP_FILTER_ALL)
> > +		skb_hwtstamps(skb)->hwtstamp = EEA_DESC_TS(desc) +
> > +			enet->hw_ts_offset;
> > +
>
> These two hunks are nothing to do with ethtool.
>
> Otherwise this code looks O.K. to me.

Will move to other commit.

Thanks

>
> 	Andrew