netdev - Re: [PATCH iproute2-next v7 1/1] iproute: Extend bonding's "arp_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <743c0e51-77ea-4ecb-af1b-9558a084fa63@gmail.com>
Date: Thu, 16 Oct 2025 09:32:25 -0600
From: David Ahern <dsahern@...il.com>
To: David Wilder <wilder@...ibm.com>, netdev@...r.kernel.org
Cc: jv@...sburgh.net, pradeep@...ibm.com, i.maximets@....org,
 amorenoz@...hat.com, haliu@...hat.com, stephen@...workplumber.org
Subject: Re: [PATCH iproute2-next v7 1/1] iproute: Extend bonding's
 "arp_ip_target" parameter to add vlan tags.

On 10/13/25 5:57 PM, David Wilder wrote:
> +static struct bond_vlan_tag *bond_vlan_tags_parse(char *vlan_list, int level, int *size)

iproute2 follows netdev wrt coding standards. Please run checkpatch and
fixup long lines -- max ~80 columns. Column width in the low 80s is fine
if it improves readability versus splitting the line.

Applying: iproute: Extend bonding's "arp_ip_target" parameter to add
vlan tags.
WARNING: line length of 88 exceeds 80 columns
#18: FILE: ip/iplink_bond.c:188:
+static struct bond_vlan_tag *bond_vlan_tags_parse(char *vlan_list, int
level, int *size)

WARNING: line length of 88 exceeds 80 columns
#25: FILE: ip/iplink_bond.c:195:
+		fprintf(stderr, "Error: Too many vlan tags specified, maximum is %d.\n",

WARNING: line length of 96 exceeds 80 columns
#46: FILE: ip/iplink_bond.c:216:
+		if (n != 1 || tags[level].vlan_id < 1 || tags[level].vlan_id >=
VLAN_VID_MASK) {

...