netdev - Re: [PATCH leds v2 00/10] Add support for offloading netdev trigger to HW + example implementation for Turris Omnia

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8vv=5yRDD-fRMohTiJ=8j-1Nq-Q7iU16Opoe0PywFb6Zg@mail.gmail.com>
Date: Thu, 16 Oct 2025 20:25:49 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Marek Behún <kabel@...nel.org>, 
	linux-leds@...r.kernel.org, netdev@...r.kernel.org, 
	Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>, Russell King <linux@...linux.org.uk>, 
	Matthias Schiffer <matthias.schiffer@...tq-group.com>, 
	Jacek Anaszewski <jacek.anaszewski@...il.com>, 
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH leds v2 00/10] Add support for offloading netdev trigger
 to HW + example implementation for Turris Omnia

Hi Andrew,

On Thu, Oct 16, 2025 at 8:11 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Thu, Oct 16, 2025 at 07:53:17PM +0100, Lad, Prabhakar wrote:
> > Hi Andrew,
> >
> > On Thu, Oct 16, 2025 at 2:14 PM Andrew Lunn <andrew@...n.ch> wrote:
> > >
> > > > > Marek Behún (10):
> > > > >   leds: trigger: netdev: don't explicitly zero kzalloced data
> > > > >   leds: trigger: add API for HW offloading of triggers
> > > > >   leds: trigger: netdev: move trigger data structure to global include
> > > > >     dir
> > > > >   leds: trigger: netdev: support HW offloading
> > > > >   leds: trigger: netdev: change spinlock to mutex
> > > > >   leds: core: inform trigger that it's deactivation is due to LED
> > > > >     removal
> > > > >   leds: turris-omnia: refactor sw mode setting code into separate
> > > > >     function
> > > > >   leds: turris-omnia: refactor brightness setting function
> > > > >   leds: turris-omnia: initialize each multicolor LED to white color
> > > > >   leds: turris-omnia: support offloading netdev trigger for WAN LED
> > > > >
> > > > Do you plan to progress with the above series anytime soon? If not I
> > > > want to give this patch [0] again a respin.
> > >
> > > What features are you missing from the current kernel code, which this
> > > series adds?
> > >
> > I’m working on a platform that uses the VSC8541 PHY. On this platform,
> > LED0 and LED1 are connected to the external connector, and LED1 is
> > also connected to the Ethernet switch to indicate the PHY link status.
> > As a result, whenever there is link activity, the PHY link status
> > signal to the switch toggles, causing the switch to incorrectly detect
> > the link as going up and down.
>
> So you think the current /sys/class/leds code is not sufficient. You
> can use it from udev etc, to make the LED indicate link, but then
> userspace could change it to something else. I _think_ only root can
> use /sys/class/leds to change the function of the LED, so it is not
> too bad as is? Or do you really want to make the configuration read
> only?
>
I haven't explored the current leds code tbh. Can you please point me
to any PHY which uses leds if any.

Cheers,
Prabhakar