netdev - RE: [Intel-wired-lan] [PATCH iwl-next v8 3/9] idpf: move queue resources to idpf_q_vec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM4PR11MB650248B56B99080A2AEBFE0FD4E9A@DM4PR11MB6502.namprd11.prod.outlook.com>
Date: Thu, 16 Oct 2025 23:03:16 +0000
From: "Hay, Joshua A" <joshua.a.hay@...el.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v8 3/9] idpf: move queue
 resources to idpf_q_vec_rsrc structure

> Dear Joshua,
> 
> 
> Thank you for the patch.
> 
> Am 14.10.25 um 01:13 schrieb Joshua Hay:
> > From: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
> >
> > Move both TX and RX queue resources to the newly introduced
> > idpf_q_vec_rsrc structure.
> 
> What is the motivation for doing this?

The main motivation is to decouple the queue resources from the vport structure. The previous implementations of the config path functions assumes we're operating on all the queues attached to a specific vport. By moving the queue resources into this queue resource specific struct, we can configure arbitrary queue groups, and more importantly ones that are not associated to a specific vport struct, e.g. control queues. This is critical for use cases where additional control queues are necessary. The PTP secondary mailbox is one such use case, which is needed to improve PTP latency. With this change, any additional control queues can be allocated, configured, and enabled, without having to allocate a dummy vport struct associated with those queues. 

> 
> 
> > While at it, declare the loop iterator in loop and use the correct type.
> 
> Please make this a separate commit, as the diff is already big enough.

Sure, will do.

Thanks!
Josh

> 
> 
> Kind regards,
> 
> Paul
> 
> 
> > Reviewed-by: Anton Nadezhdin <anton.nadezhdin@...el.com>
> > Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
> > Signed-off-by: Joshua Hay <joshua.a.hay@...el.com>
> > ---
> > v8:
> > - rebase on AF_XDP series
> > - remove dev param from rx_desc_rel and access through q_vector
> > - introduce per queue RSC flag to avoid vport check
> > ---
> >   drivers/net/ethernet/intel/idpf/idpf.h        |  69 +--
> >   .../net/ethernet/intel/idpf/idpf_ethtool.c    |  91 ++--
> >   drivers/net/ethernet/intel/idpf/idpf_lib.c    |  71 +--
> >   drivers/net/ethernet/intel/idpf/idpf_ptp.c    |  17 +-
> >   drivers/net/ethernet/intel/idpf/idpf_txrx.c   | 451 +++++++++---------
> >   drivers/net/ethernet/intel/idpf/idpf_txrx.h   |  21 +-
> >   .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 258 +++++-----
> >   .../net/ethernet/intel/idpf/idpf_virtchnl.h   |  12 +-
> >   drivers/net/ethernet/intel/idpf/xdp.c         |  37 +-
> >   drivers/net/ethernet/intel/idpf/xdp.h         |   6 +-
> >   drivers/net/ethernet/intel/idpf/xsk.c         |   7 +-
> >   11 files changed, 561 insertions(+), 479 deletions(-)
> 
> […]