netdev - Re: [PATCH net v3] net: cxgb4/ch_ipsec: fix potential use-after-free in ch_ipsec_xfrm_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251015172649.279cf382@kernel.org>
Date: Wed, 15 Oct 2025 17:26:49 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>
Cc: Paolo Abeni <pabeni@...hat.com>, Zhu Yanjun <yanjun.zhu@...ux.dev>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Leon Romanovsky
 <leon@...nel.org>, Steffen Klassert <steffen.klassert@...unet.com>, Cosmin
 Ratiu <cratiu@...dia.com>, Ayush Sawal <ayush.sawal@...lsio.com>, Harsh
 Jain <harsh@...lsio.com>, Atul Gupta <atul.gupta@...lsio.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, Ganesh Goudar <ganeshgr@...lsio.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <lvc-project@...uxtesting.org>
Subject: Re: [PATCH net v3] net: cxgb4/ch_ipsec: fix potential
 use-after-free in ch_ipsec_xfrm_add_state() callback

On Mon, 13 Oct 2025 12:58:08 +0300 Pavel Zhigulin wrote:
> +	if (unlikely(!try_module_get(THIS_MODULE))) {
> +		NL_SET_ERR_MSG_MOD(extack, "Failed to acquire module reference");
> +		return -ENODEV;
> +	}
> +
>  	sa_entry = kzalloc(sizeof(*sa_entry), GFP_KERNEL);
>  	if (!sa_entry) {
>  		res = -ENOMEM;

I think now you're missing a module put if something fails later.
-- 
pw-bot: cr