netdev - Re: [PATCH net-next 00/14] net: stmmac: phylink PCS conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8bf183c-964c-4e97-b7f0-f2cb0560f784@bootlin.com>
Date: Thu, 16 Oct 2025 09:44:38 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>,
 Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
Cc: Abhishek Chauhan <quic_abchauha@...cinc.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Alexis Lothore <alexis.lothore@...tlin.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, Boon Khai Ng <boon.khai.ng@...era.com>,
 Choong Yong Liang <yong.liang.choong@...ux.intel.com>,
 Daniel Machon <daniel.machon@...rochip.com>,
 "David S. Miller" <davem@...emloft.net>,
 Drew Fustini <dfustini@...storrent.com>,
 Emil Renner Berthing <emil.renner.berthing@...onical.com>,
 Eric Dumazet <edumazet@...gle.com>,
 Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>,
 Furong Xu <0x1207@...il.com>, Inochi Amaoto <inochiama@...il.com>,
 Jacob Keller <jacob.e.keller@...el.com>, Jakub Kicinski <kuba@...nel.org>,
 "Jan Petrous (OSS)" <jan.petrous@....nxp.com>,
 Jisheng Zhang <jszhang@...nel.org>, Kees Cook <kees@...nel.org>,
 Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 Ley Foon Tan <leyfoon.tan@...rfivetech.com>,
 linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 Matthew Gerlach <matthew.gerlach@...era.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
 netdev@...r.kernel.org, Oleksij Rempel <o.rempel@...gutronix.de>,
 Paolo Abeni <pabeni@...hat.com>, Rohan G Thomas <rohan.g.thomas@...era.com>,
 Shenwei Wang <shenwei.wang@....com>, Simon Horman <horms@...nel.org>,
 Song Yoong Siang <yoong.siang.song@...el.com>,
 Swathi K S <swathi.ks@...sung.com>, Tiezhu Yang <yangtiezhu@...ngson.cn>,
 Vinod Koul <vkoul@...nel.org>, Vladimir Oltean <olteanv@...il.com>,
 Vladimir Oltean <vladimir.oltean@....com>, Yu-Chun Lin <eleanor15x@...il.com>
Subject: Re: [PATCH net-next 00/14] net: stmmac: phylink PCS conversion

Hi Russell,

On 15/10/2025 17:10, Russell King (Oracle) wrote:
> On Wed, Oct 15, 2025 at 03:19:25PM +0100, Russell King (Oracle) wrote:
>> Changes since RFC:
>> - new patch (7) to remove RGMII "pcs" mode
>> - new patch (8) to move reverse "pcs" mode to stmmac_check_pcs_mode()
>> - new patch (9) to simplify the code moved in the previous patch
>> - new patch (10) to rename the confusing hw->ps to something more
>>   understandable.
>> - new patch (11) to shut up inappropriate complaints about
>>   "snps,ps-speed" being invalid.
>> - new patch (13) to add a MAC .pcs_init method, which will only be
>>   called when core has PCS present.
>> - modify patch 14 to use this new pcs_init method.
> 
> I've just noticed I sent out RFC v2.. completely forgot about that,
> sorry

:( I don't know if you saw my reply to it then...

To quote :
"
  I tested that series on socfpga with :

    - 1 instance using RGMII, w/ a ksz9031 PHY, and it works well,
      traffic flows, ethtool seems to report correct data

    - 1 instance that has the Lynx PCS (DMA_HW_FEATURE[30:28] == 0)

  This also works perfectly, switching between SGMII/1000BaseX dynamically
  by hotswapping SFP modules works well, no regression found at a first glance.
"

All the boards I have that have a flavour of stmmac don't seem to have the
internal PCS, are you still interested in some testing , just
for non-regression ?

 This is a subset of RFC v2, but with patches 13 and 14
> reversed.
> 
Maxime