netdev - Re: [PATCH net-next] net/hsr: add interlink to fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f9742f5-8889-449d-8354-572d2f8a711b@suse.de>
Date: Fri, 17 Oct 2025 12:17:21 +0200
From: Fernando Fernandez Mancera <fmancera@...e.de>
To: Jakub Kicinski <kuba@...nel.org>, Jan Vaclav <jvaclav@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net/hsr: add interlink to fill_info output

On 10/17/25 12:57 AM, Jakub Kicinski wrote:
> On Wed, 15 Oct 2025 12:10:02 +0200 Jan Vaclav wrote:
>> Currently, it is possible to configure the interlink port, but no
>> way to read it back from userspace.
>> 
>> Add it to the output of hsr_fill_info(), so it can be read from
>> userspace, for example:
>> 
>> $ ip -d link show hsr0 12: hsr0: <BROADCAST,MULTICAST> mtu ... ... 
>> hsr slave1 veth0 slave2 veth1 interlink veth2 ...
> 
> Not entirely cleat at a glance how this driver deals with the slaves
> or interlink being in a different netns, but I guess that's a pre-
> existing problem..
> 

FTR, I just did a quick round of testing and it handles it correctly. 
When moving a port to a different netns it notifies NETDEV_UNREGISTER - 
net/hsr/hsr_main.c handles the notification removing the port from the 
list. If the port list is empty, removes the hsr link.

All good or at least as I would expect.

Thanks,
Fernando.