netdev - Re: [PATCH net-next 6/6] net: hns3: add hwtstamp_get/hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202510171940.xIqxEaCD-lkp@intel.com>
Date: Fri, 17 Oct 2025 19:19:17 +0800
From: kernel test robot <lkp@...el.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Jian Shen <shenjian15@...wei.com>,
	Salil Mehta <salil.mehta@...wei.com>,
	Jijie Shao <shaojijie@...wei.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Sunil Goutham <sgoutham@...vell.com>,
	Geetha sowjanya <gakula@...vell.com>,
	Subbaraya Sundeep <sbhatta@...vell.com>,
	Bharat Bhushan <bbhushan2@...vell.com>,
	Tariq Toukan <tariqt@...dia.com>,
	Brett Creeley <brett.creeley@....com>,
	Niklas Söderlund <niklas.soderlund@...natech.se>,
	Paul Barker <paul@...rker.dev>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org,
	Richard Cochran <richardcochran@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Simon Horman <horms@...nel.org>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH net-next 6/6] net: hns3: add hwtstamp_get/hwtstamp_set ops

Hi Vadim,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Vadim-Fedorenko/octeontx2-convert-to-ndo_hwtstamp-API/20251017-021210
base:   net-next/main
patch link:    https://lore.kernel.org/r/20251016180727.3511399-7-vadim.fedorenko%40linux.dev
patch subject: [PATCH net-next 6/6] net: hns3: add hwtstamp_get/hwtstamp_set ops
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20251017/202510171940.xIqxEaCD-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251017/202510171940.xIqxEaCD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510171940.xIqxEaCD-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:2436:12: warning: 'hns3_nic_hwtstamp_set' defined but not used [-Wunused-function]
    2436 | static int hns3_nic_hwtstamp_set(struct net_device *netdev,
         |            ^~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:2422:12: warning: 'hns3_nic_hwtstamp_get' defined but not used [-Wunused-function]
    2422 | static int hns3_nic_hwtstamp_get(struct net_device *netdev,
         |            ^~~~~~~~~~~~~~~~~~~~~


vim +/hns3_nic_hwtstamp_set +2436 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

  2421	
> 2422	static int hns3_nic_hwtstamp_get(struct net_device *netdev,
  2423					 struct kernel_hwtstamp_config *config)
  2424	{
  2425		struct hnae3_handle *h = hns3_get_handle(netdev);
  2426	
  2427		if (!netif_running(netdev))
  2428			return -EINVAL;
  2429	
  2430		if (!h->ae_algo->ops->hwtstamp_get)
  2431			return -EOPNOTSUPP;
  2432	
  2433		return h->ae_algo->ops->hwtstamp_get(h, config);
  2434	}
  2435	
> 2436	static int hns3_nic_hwtstamp_set(struct net_device *netdev,
  2437					 struct kernel_hwtstamp_config *config,
  2438					 struct netlink_ext_ack *extack)
  2439	{
  2440		struct hnae3_handle *h = hns3_get_handle(netdev);
  2441	
  2442		if (!netif_running(netdev))
  2443			return -EINVAL;
  2444	
  2445		if (!h->ae_algo->ops->hwtstamp_set)
  2446			return -EOPNOTSUPP;
  2447	
  2448		return h->ae_algo->ops->hwtstamp_set(h, config, extack);
  2449	}
  2450	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki