netdev - Re: [PATCH net-next v6 4/5] net: phy: micrel: add MSE interface support for KSZ9477 family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebc5327f-49b6-4135-bdbf-c5007f3f97ac@bootlin.com>
Date: Fri, 17 Oct 2025 16:27:42 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>, Andrew Lunn <andrew@...n.ch>,
 Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Donald Hunter <donald.hunter@...il.com>,
 Jonathan Corbet <corbet@....net>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>,
 Kory Maincent <kory.maincent@...tlin.com>, Nishanth Menon <nm@...com>
Cc: kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
 linux-doc@...r.kernel.org, Michal Kubecek <mkubecek@...e.cz>,
 Roan van Dijk <roan@...tonic.nl>
Subject: Re: [PATCH net-next v6 4/5] net: phy: micrel: add MSE interface
 support for KSZ9477 family

Hi Oleksij,

On 17/10/2025 12:47, Oleksij Rempel wrote:
> Implement the get_mse_capability() and get_mse_snapshot() PHY driver ops
> for KSZ9477-series integrated PHYs to demonstrate the new PHY MSE
> UAPI.
> 
> These PHYs do not expose a documented direct MSE register, but the
> Signal Quality Indicator (SQI) registers are derived from the
> internal MSE computation. This hook maps SQI readings into the MSE
> interface so that tooling can retrieve the raw value together with
> metadata for correct interpretation in userspace.
> 
> Behaviour:
>   - For 1000BASE-T, report per-channel (A–D) values and support a
>     WORST channel selector.
>   - For 100BASE-TX, only LINK-wide measurements are available.
>   - Report average MSE only, with a max scale based on
>     KSZ9477_MMD_SQI_MASK and a fixed refresh rate of 2 µs.
> 
> This mapping differs from the OPEN Alliance SQI definition, which
> assigns thresholds such as pre-fail indices; the MSE interface
> instead provides the raw measurement, leaving interpretation to
> userspace.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Maxime