netdev - Re: [PATCH net-next] bnxt_en: support PPS in/out on all pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv2gcHTpGRhZOPQqd+JrNnL05xLFYWB3uaznNbcGt=x03A@mail.gmail.com>
Date: Fri, 17 Oct 2025 09:15:06 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Michael Chan <michael.chan@...adcom.com>, Jakub Kicinski <kuba@...nel.org>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
	Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bnxt_en: support PPS in/out on all pins

On Fri, Oct 17, 2025 at 3:54 AM Vadim Fedorenko
<vadim.fedorenko@...ux.dev> wrote:
>
> n_ext_ts and n_per_out from ptp_clock_caps are checked as a max number
> of pins rather than max number of active pins.

I am not 100pc sure. How is n_pins going to be different then?
https://elixir.bootlin.com/linux/v6.17/source/include/linux/ptp_clock_kernel.h#L69

>
> supported_extts_flags and supported_perout_flags have to be added as
> well to make the driver complaint with the latest API.
>
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> index db81cf6d5289..c9b7df669415 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> @@ -965,10 +965,12 @@ static int bnxt_ptp_pps_init(struct bnxt *bp)
>         hwrm_req_drop(bp, req);
>
>         /* Only 1 each of ext_ts and per_out pins is available in HW */
> -       ptp_info->n_ext_ts = 1;
> -       ptp_info->n_per_out = 1;
> +       ptp_info->n_ext_ts = pps_info->num_pins;
> +       ptp_info->n_per_out = pps_info->num_pins;
>         ptp_info->pps = 1;
>         ptp_info->verify = bnxt_ptp_verify;
> +       ptp_info->supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS;
> +       ptp_info->supported_perout_flags = PTP_PEROUT_DUTY_CYCLE;
>
>         return 0;
>  }
> --
> 2.47.3
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)