netdev - Re: [PATCH net-next 2/2] net: dsa: loop: use new helper fixed_phy_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f807acdf-51f1-432f-8dc5-7d783c04f83a@engleder-embedded.com>
Date: Fri, 17 Oct 2025 22:43:29 +0200
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Andrew Lunn <andrew@...n.ch>, Andrew Lunn <andrew+netdev@...n.ch>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next 2/2] net: dsa: loop: use new helper
 fixed_phy_register_100fd

On 17.10.25 22:14, Heiner Kallweit wrote:
> Use new helper fixed_phy_register_100fd() to simplify the code.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>   drivers/net/dsa/dsa_loop.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
> index 650d93226..4a416f271 100644
> --- a/drivers/net/dsa/dsa_loop.c
> +++ b/drivers/net/dsa/dsa_loop.c
> @@ -441,11 +441,6 @@ static int __init dsa_loop_create_switch_mdiodev(void)
>   
>   static int __init dsa_loop_init(void)
>   {
> -	struct fixed_phy_status status = {
> -		.link = 1,
> -		.speed = SPEED_100,
> -		.duplex = DUPLEX_FULL,
> -	};
>   	unsigned int i;
>   	int ret;
>   
> @@ -454,7 +449,7 @@ static int __init dsa_loop_init(void)
>   		return ret;
>   
>   	for (i = 0; i < NUM_FIXED_PHYS; i++)
> -		phydevs[i] = fixed_phy_register(&status, NULL);
> +		phydevs[i] = fixed_phy_register_100fd();
>   
>   	ret = mdio_driver_register(&dsa_loop_drv);
>   	if (ret) {

Reviewed-by: Gerhard Engleder <gerhard@...leder-embedded.com>