netdev - Re: [PATCH net-next 10/14] ionic: convert to ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eff0d886-ff55-4771-9c97-d7535081dfc0@linux.dev>
Date: Sat, 18 Oct 2025 14:51:54 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Brett Creeley <bcreeley@....com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Igor Russkikh <irusskikh@...vell.com>, Egor Pomozov <epomozov@...vell.com>,
 Potnuri Bharat Teja <bharat@...lsio.com>,
 Dimitris Michailidis <dmichail@...gible.com>,
 Jian Shen <shenjian15@...wei.com>, Salil Mehta <salil.mehta@...wei.com>,
 Jijie Shao <shaojijie@...wei.com>, Sunil Goutham <sgoutham@...vell.com>,
 Geetha sowjanya <gakula@...vell.com>, Subbaraya Sundeep
 <sbhatta@...vell.com>, Bharat Bhushan <bbhushan2@...vell.com>,
 Tariq Toukan <tariqt@...dia.com>, Brett Creeley <brett.creeley@....com>,
 Niklas Söderlund <niklas.soderlund@...natech.se>,
 Paul Barker <paul@...rker.dev>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
 MD Danish Anwar <danishanwar@...com>, Roger Quadros <rogerq@...nel.org>
Cc: Richard Cochran <richardcochran@...il.com>,
 Russell King <linux@...linux.org.uk>,
 Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH net-next 10/14] ionic: convert to ndo_hwtstamp API

On 17/10/2025 18:11, Brett Creeley wrote:
>> ionic_netdev_ops = {
>>          .ndo_get_vf_config      = ionic_get_vf_config,
>>          .ndo_set_vf_link_state  = ionic_set_vf_link_state,
>>          .ndo_get_vf_stats       = ionic_get_vf_stats,
>> +       .ndo_hwtstamp_get       = ionic_lif_hwstamp_get,
>> +       .ndo_hwtstamp_set       = ionic_lif_hwstamp_set,
> 
> Nit, but if you are changing this and you have to re-spin the series it 
> would align with the other ndo callbacks to rename these by removing the 
> "_lif_" portion of the name:
> 
>    ionic_hwstamp_get
>    ionic_hwstamp_set
> 
> Other than that LGTM.
> 
> Reviewed-by: Brett Creeley <brett.creeley@....com>

Thanks Brett, I took your suggestion before sending out v2.