netdev - Re: [PATCH mlx5-next] {rdma,net}/mlx5: Query vports mac address from device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251019125923.GI6199@unreal>
Date: Sun, 19 Oct 2025 15:59:23 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Saeed Mahameed <saeed@...nel.org>
Cc: Saeed Mahameed <saeedm@...dia.com>, Jason Gunthorpe <jgg@...dia.com>,
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	Tariq Toukan <tariqt@...dia.com>,
	Adithya Jayachandran <ajayachandra@...dia.com>,
	Mark Bloch <mbloch@...dia.com>
Subject: Re: [PATCH mlx5-next] {rdma,net}/mlx5: Query vports mac address from
 device

On Wed, Oct 15, 2025 at 06:40:55PM -0700, Saeed Mahameed wrote:
> From: Adithya Jayachandran <ajayachandra@...dia.com>
> 
> Before this patch during either switchdev or legacy mode enablement we
> cleared the mac address of vports between changes. This change allows us
> to preserve the vports mac address between eswitch mode changes.
> 
> Signed-off-by: Adithya Jayachandran <ajayachandra@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> Reviewed-by: Mark Bloch <mbloch@...dia.com>
> ---
>  drivers/infiniband/hw/mlx5/main.c             |  2 +-
>  .../net/ethernet/mellanox/mlx5/core/eswitch.c | 20 ++++++----------
>  .../mellanox/mlx5/core/eswitch_offloads.c     |  3 +++
>  .../net/ethernet/mellanox/mlx5/core/vport.c   | 24 +++++++++----------
>  include/linux/mlx5/vport.h                    |  3 ++-
>  5 files changed, 25 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index fc1e86f6c409..90daa58126f4 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -842,7 +842,7 @@ static int mlx5_query_node_guid(struct mlx5_ib_dev *dev,
>  		break;
>  
>  	case MLX5_VPORT_ACCESS_METHOD_NIC:
> -		err = mlx5_query_nic_vport_node_guid(dev->mdev, &tmp);
> +		err = mlx5_query_nic_vport_node_guid(dev->mdev, 0, false, &tmp);
>  		break;

IB changes are pretty straightforward.

Thanks,
Acked-by: Leon Romanovsky <leon@...nel.org> # RDMA