netdev - Re: [PATCH ipsec 4/6] xfrm: call xfrm_dev_state_delete when xfrm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251019134612.GJ6199@unreal>
Date: Sun, 19 Oct 2025 16:46:12 +0300
From: Leon Romanovsky <leonro@...dia.com>
To: Sabrina Dubroca <sd@...asysnail.net>
CC: <netdev@...r.kernel.org>, <steffen.klassert@...unet.com>, Chiachang Wang
	<chiachangwang@...gle.com>
Subject: Re: [PATCH ipsec 4/6] xfrm: call xfrm_dev_state_delete when
 xfrm_state_migrate fails to add the state

On Thu, Oct 16, 2025 at 12:39:15PM +0200, Sabrina Dubroca wrote:
> In case xfrm_state_migrate fails after calling xfrm_dev_state_add, we
> directly release the last reference and destroy the new state, without
> calling xfrm_dev_state_delete (this only happens in
> __xfrm_state_delete, which we're not calling on this path, since the
> state was never added).
> 
> Call xfrm_dev_state_delete on error when an offload configuration was
> provided.
> 
> Fixes: ab244a394c7f ("xfrm: Migrate offload configuration")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
> ---
>  net/xfrm/xfrm_state.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>