netdev - Re: [PATCH net-next v2] bnxt_en: support PPS in/out on all pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv3y8Yb+978zUrteNOwj=LP6UdjqFzdtXOL5rUfoxcSGNA@mail.gmail.com>
Date: Mon, 20 Oct 2025 16:38:22 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Michael Chan <michael.chan@...adcom.com>, Jakub Kicinski <kuba@...nel.org>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
	Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] bnxt_en: support PPS in/out on all pins

On Mon, Oct 20, 2025 at 4:27 AM Vadim Fedorenko
<vadim.fedorenko@...ux.dev> wrote:
>
> Add supported_extts_flags and supported_perout_flags configuration to make
> the driver complaint with the latest API.
>
> Initialize channel information to 0 to avoid confusing users, because HW
> doesn't actually care about channels.
>
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> index db81cf6d5289..1425a75de9a1 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> @@ -952,7 +952,6 @@ static int bnxt_ptp_pps_init(struct bnxt *bp)
>                 snprintf(ptp_info->pin_config[i].name,
>                          sizeof(ptp_info->pin_config[i].name), "bnxt_pps%d", i);
>                 ptp_info->pin_config[i].index = i;
> -               ptp_info->pin_config[i].chan = i;
>                 if (*pin_usg == BNXT_PPS_PIN_PPS_IN)
>                         ptp_info->pin_config[i].func = PTP_PF_EXTTS;
>                 else if (*pin_usg == BNXT_PPS_PIN_PPS_OUT)
> @@ -969,6 +968,8 @@ static int bnxt_ptp_pps_init(struct bnxt *bp)
>         ptp_info->n_per_out = 1;
>         ptp_info->pps = 1;
>         ptp_info->verify = bnxt_ptp_verify;
> +       ptp_info->supported_extts_flags = PTP_RISING_EDGE | PTP_STRICT_FLAGS;
> +       ptp_info->supported_perout_flags = PTP_PEROUT_DUTY_CYCLE;
>
>         return 0;
>  }

Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

> --
> 2.47.3
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)