netdev - Re: [PATCH net-next] devlink: region: correct port region lookup to use port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <hfc4vawmkduyqmsbuuebrjrbnzkwuqq6ylpm3molh6zfnvgwv4@jyc52nrejlef>
Date: Mon, 20 Oct 2025 13:43:40 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org, 
	alok.a.tiwarilinux@...il.com
Subject: Re: [PATCH net-next] devlink: region: correct port region lookup to
 use port_ops

Sun, Oct 19, 2025 at 06:17:27PM +0200, alok.a.tiwari@...cle.com wrote:
>The function devlink_port_region_get_by_name() incorrectly uses
>region->ops->name to compare the region name. as it is not any critical
>imapce as ops and port_pos define as union for devlink_region but as per

"impact"?
"port_ops"?

>code logica it should refer port_ops here.
>
>no functional impact as ops and port_ops are part of same union.
>
>Update it to use region->port_ops->name to properly reference
>the name of the devlink port region.
>
>Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>


>---
> net/devlink/region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/net/devlink/region.c b/net/devlink/region.c
>index 63fb297f6d67..d6e5805cf3a0 100644
>--- a/net/devlink/region.c
>+++ b/net/devlink/region.c
>@@ -50,7 +50,7 @@ devlink_port_region_get_by_name(struct devlink_port *port,
> 	struct devlink_region *region;
> 
> 	list_for_each_entry(region, &port->region_list, list)
>-		if (!strcmp(region->ops->name, region_name))
>+		if (!strcmp(region->port_ops->name, region_name))
> 			return region;
> 
> 	return NULL;
>-- 
>2.50.1
>