netdev - Re: [PATCH net v2 1/3] net: datagram: introduce datagram_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59cdb31136683ba0163a7499158c4a8090fb4e41.camel@mandelbit.com>
Date: Mon, 20 Oct 2025 14:22:34 +0200
From: Ralf Lici <ralf@...delbit.com>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>,  Simon Horman <horms@...nel.org>, Mina Almasry
 <almasrymina@...gle.com>, Eric Biggers <ebiggers@...gle.com>,  Antonio
 Quartulli <antonio@...nvpn.net>
Subject: Re: [PATCH net v2 1/3] net: datagram: introduce datagram_poll_queue
 for custom receive queues

On Mon, 2025-10-20 at 12:17 +0200, Sabrina Dubroca wrote:
> LGTM, just a small nit:
> 
> 2025-10-20, 09:37:29 +0200, Ralf Lici wrote:
> > +/**
> > + *	datagram_poll - generic datagram poll
> > + *	@file: file struct
> > + *	@sock: socket
> > + *	@wait: poll table
> > + *
> > + *	Datagram poll: Again totally generic. This also handles
> > + *	sequenced packet sockets providing the socket receive queue
> > + *	is only ever holding data ready to receive.
> > + *
> > + *	Note: when you *don't* use this routine for this protocol,
> > + *	and you use a different write policy from sock_writeable()
> > + *	then please supply your own write_space callback.
> 
> Maybe you could document the return value here as well, since you're
> touching this code.

Will do.

-- 
Ralf Lici
Mandelbit Srl