netdev - Re: [PATCH net-next v2]: 3c515 : replace cleanup_module with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPYxbwjIlyPHrTY3@horms.kernel.org>
Date: Mon, 20 Oct 2025 13:56:15 +0100
From: Simon Horman <horms@...nel.org>
To: Shi Hao <i.shihao.999@...il.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH  net-next v2]: 3c515 : replace cleanup_module with __exit

On Sat, Oct 18, 2025 at 10:55:41AM +0530, Shi Hao wrote:
> update old legacy cleanup_module from the file with __exit
> module as per kernel code practices and restore the #ifdef
> MODULE condition to allow successful compilation as a built
> -in driver.
> 
> The file had an old cleanup_module still in use which could
> be updated with __exit module function although its init_module
> is indeed newer however the cleanup_module was still
> using the older version of exit.
> 
> To set proper exit module function replace cleanup_module
> with __exit corkscrew_exit_module to align it to the
> kernel code consistency.
> 
> Signed-off-by: Shi Hao <i.shihao.999@...il.com>
> 
> ---
> 
> changes v2:
> - Restore ifdef module condition to compile as built in module
> - Adjust subject prefix from "net:ethernet" to "3c515"

Thanks for the update.
The code changes in this version look good to me.

One minor nit: the whitespace in the subject look slightly off.
There is probably no need to repost because of this.
But I would have gone for:

Subject: [PATCH net-next v2] 3c515: replace cleanup_module with __exit

But overall this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>