lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1760943954-909301-1-git-send-email-tariqt@nvidia.com>
Date: Mon, 20 Oct 2025 10:05:51 +0300
From: Tariq Toukan <tariqt@...dia.com>
To: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>
CC: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
	Tariq Toukan <tariqt@...dia.com>, Mark Bloch <mbloch@...dia.com>, "John
 Fastabend" <john.fastabend@...il.com>, Sabrina Dubroca <sd@...asysnail.net>,
	<netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Gal Pressman <gal@...dia.com>, Shahar Shitrit
	<shshitrit@...dia.com>
Subject: [PATCH net V2 0/3] tls: Introduce and use RX async resync request cancel function

Hi,

This is V2. Find previous one here:
https://lore.kernel.org/all/1757486861-542133-1-git-send-email-tariqt@nvidia.com/

This series by Shahar introduces RX async resync request cancel function
in tls module, and uses it in mlx5e driver.

For a device-offloaded TLS RX connection, the TLS module increments
rcd_delta each time a new TLS record is received, tracking the distance
from the original resync request. In the meanwhile, the device is
queried and is expected to respond, asynchronously.

However, if the device response is delayed or fails (e.g due to unstable
connection and device getting out of tracking, hardware errors, resource
exhaustion etc.), the TLS module keeps logging and incrementing
rcd_delta, which can lead to a WARN() when rcd_delta exceeds the
threshold.

This series improves this code area by canceling the resync request when
spotting an issue with the device response.

Regards,
Tariq


V2:
- Introduce and use tls_offload_rx_resync_async_request_cancel()
  in tls module in one patch.
- Change argument type for tls_offload_rx_resync_async_request_start()
  and tls_offload_rx_resync_async_request_end().

Shahar Shitrit (3):
  net: tls: Change async resync helpers argument
  net: tls: Cancel RX async resync request on rdc_delta overflow
  net/mlx5e: kTLS, Cancel RX async resync request in error flows

 .../mellanox/mlx5/core/en_accel/ktls_rx.c     | 40 ++++++++++++++++---
 .../mellanox/mlx5/core/en_accel/ktls_txrx.h   |  4 ++
 .../net/ethernet/mellanox/mlx5/core/en_rx.c   |  4 ++
 include/net/tls.h                             | 25 ++++++------
 net/tls/tls_device.c                          |  4 +-
 5 files changed, 59 insertions(+), 18 deletions(-)


base-commit: ffff5c8fc2af2218a3332b3d5b97654599d50cde
-- 
2.31.1


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ