netdev - Re: [PATCH net-next] net: hibmcge: select FIXED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e932d815-5c06-4fd8-a766-72581b1865f0@huawei.com>
Date: Mon, 20 Oct 2025 16:07:18 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Jian Shen <shenjian15@...wei.com>,
	Salil Mehta <salil.mehta@...wei.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, David
 Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>
CC: <shaojijie@...wei.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: hibmcge: select FIXED_PHY


on 2025/10/20 14:54, Heiner Kallweit wrote:
> hibmcge uses fixed_phy_register() et al, but doesn't cater for the case
> that hibmcge is built-in and fixed_phy is a module. To solve this

hibmcge can also be set as a module.(CONFIG_HIBMCGE=m)

> select FIXED_PHY.

Thanks,
Reviewed-by: Jijie Shao <shaojijie@...wei.com>

>
> Note: This could also be treated as a fix, but as no problems are known,
> treat it as an improvement.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>   drivers/net/ethernet/hisilicon/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
> index 65302c41b..38875c196 100644
> --- a/drivers/net/ethernet/hisilicon/Kconfig
> +++ b/drivers/net/ethernet/hisilicon/Kconfig
> @@ -148,6 +148,7 @@ config HIBMCGE
>   	tristate "Hisilicon BMC Gigabit Ethernet Device Support"
>   	depends on PCI && PCI_MSI
>   	select PHYLIB
> +	select FIXED_PHY
>   	select MOTORCOMM_PHY
>   	select REALTEK_PHY
>   	help