netdev - Re: [PATCHv6 net-next 4/4] net: bridge: use common function to compute the features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPX-O9vPowb_tb2U@krikkit>
Date: Mon, 20 Oct 2025 11:17:47 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <jv@...sburgh.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jiri Pirko <jiri@...nulli.us>, Simon Horman <horms@...nel.org>,
	Ido Schimmel <idosch@...dia.com>, Shuah Khan <shuah@...nel.org>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Stanislav Fomichev <stfomichev@...il.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	bridge@...ts.linux.dev
Subject: Re: [PATCHv6 net-next 4/4] net: bridge: use common function to
 compute the features

2025-10-17, 03:41:55 +0000, Hangbin Liu wrote:
> Previously, bridge ignored all features propagation and DST retention,
> only handling explicitly the GSO limits.
> 
> By switching to the new helper netdev_compute_master_upper_features(), the bridge
> now expose additional features, depending on the lowers capabilities.
> 
> Since br_set_gso_limits() is already covered by the helper, it can be
> removed safely.
> 
> Bridge has it's own way to update needed_headroom. So we don't need to
> update it in the helper.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  net/bridge/br_if.c | 22 +++-------------------
>  1 file changed, 3 insertions(+), 19 deletions(-)

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

-- 
Sabrina