netdev - Re: [PATCH net v5 2/3] net: usb: ax88179_178a: add USB device driver for config selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025102007-garland-splendid-abc9@gregkh>
Date: Mon, 20 Oct 2025 12:48:18 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Oliver Neukum <oneukum@...e.com>, Michal Pecio <michal.pecio@...il.com>,
	Alan Stern <stern@...land.harvard.edu>, yicongsrfy@....com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	oliver@...kum.org, pabeni@...hat.com
Subject: Re: [PATCH net v5 2/3] net: usb: ax88179_178a: add USB device driver
 for config selection

On Mon, Oct 20, 2025 at 11:59:06AM +0200, Oliver Neukum wrote:
> On 18.10.25 17:21, Michal Pecio wrote:
> 
> > index e85105939af8..1d2c5ebc81ab 100644
> > --- a/include/linux/usb.h
> > +++ b/include/linux/usb.h
> > @@ -1202,6 +1202,8 @@ extern ssize_t usb_show_dynids(struct usb_dynids *dynids, char *buf);
> >    * @post_reset: Called by usb_reset_device() after the device
> >    *	has been reset
> >    * @shutdown: Called at shut-down time to quiesce the device.
> > + * @preferred: Check if this driver is preferred over generic class drivers
> > + *	applicable to the device. May probe device with control transfers.
> >    * @id_table: USB drivers use ID table to support hotplugging.
> >    *	Export this with MODULE_DEVICE_TABLE(usb,...).  This must be set
> >    *	or your driver's probe function will never get called.
> > @@ -1255,6 +1257,8 @@ struct usb_driver {
> >   	void (*shutdown)(struct usb_interface *intf);
> > +	bool (*preferred)(struct usb_device *udev);
> 
> I am sorry, but this is a bit clunky. If you really want to
> introduce such a method, why not just return the preferred configuration?

And note, this idea has come up many many times over the past 25 years,
ever since we first added USB support to Linux.  In the end, it was
always deemed "not going to work" for a variety of real-world reasons.

I suggest reviewing the archives of the mailing list and then, if this
series is resent, documenting why this attempt is different than the
others and why it will now work properly.

thanks,

greg k-h