netdev - Re: [PATCH net-next] tsnep: convert to ndo_hwtstamp_get() and ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPdWVMFUzoSIAEHb@horms.kernel.org>
Date: Tue, 21 Oct 2025 10:45:56 +0100
From: Simon Horman <horms@...nel.org>
To: Gerhard Engleder <gerhard@...leder-embedded.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, netdev@...r.kernel.org,
	davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch,
	Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next] tsnep: convert to ndo_hwtstamp_get() and
 ndo_hwtstamp_set()

On Mon, Oct 20, 2025 at 07:59:22PM +0200, Gerhard Engleder wrote:
> On 20.10.25 12:08, Simon Horman wrote:
> > + Vadim
> > 
> > On Fri, Oct 17, 2025 at 10:34:30PM +0200, Gerhard Engleder wrote:
> > > From: Vladimir Oltean <vladimir.oltean@....com>
> > > 
> > > I took over this patch from Vladimir Oltean. The only change from my
> > > side is the adaption of the commit message. I hope I mentioned his work
> > > correctly in the tags.
> > > 
> > > New timestamping API was introduced in commit 66f7223039c0 ("net: add
> > > NDOs for configuring hardware timestamping") from kernel v6.6.
> > > 
> > > It is time to convert the tsnep driver to the new API, so that
> > > timestamping configuration can be removed from the ndo_eth_ioctl()
> > > path completely.
> > > 
> > > The driver does not need the interface to be down in order for
> > > timestamping to be changed. Thus, the netif_running() restriction in
> > > tsnep_netdev_ioctl() is not migrated to the new API. There is no
> > > interaction with hardware registers for either operation, just a
> > > concurrency with the data path which is fine.
> > > 
> > > After removing the PHY timestamping logic from tsnep_netdev_ioctl(),
> > > the rest is almost equivalent to phy_do_ioctl_running(), except for the
> > > return code on the !netif_running() condition: -EINVAL vs -ENODEV.
> > > Let's make the conversion to phy_do_ioctl_running() anyway, on the
> > > premise that a return code standardized tree-wide is less complex.
> > > 
> > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> > > Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>
> > > Tested-by: Gerhard Engleder <gerhard@...leder-embedded.com>
> > 
> > Hi Gerhard, Vladimir, Vadim, all,
> > 
> > Recently Vadim has been working on converting a number of drivers to
> > use ndo_hwtstamp_get() and ndo_hwtstamp_set(). And this includes a
> > patch, rather similar to this one, for the tsnep [1].
> > 
> > I think it would be good to agree on the way forward here.
> > 
> > [1] https://lore.kernel.org/all/20251016152515.3510991-7-vadim.fedorenko@linux.dev/
> 
> I already replied to Vadim, but on the first patch version, not on V3.
> 
> @Vadim: I reviewed your V3. Thanks for your work!
> 
> So this patch can be stopped.

Thanks for the clarification, much appreciated.