netdev - Re: [PATCH net-next v4 0/7] net: dsa: lantiq_gswip: use regmap for register access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4bf4846a4726a372825b3daa3e2f50e4eab48e57.camel@siemens.com>
Date: Tue, 21 Oct 2025 11:02:58 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "daniel@...rotopia.org" <daniel@...rotopia.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "olteanv@...il.com" <olteanv@...il.com>, "andrew@...n.ch"
	<andrew@...n.ch>, "lxu@...linear.com" <lxu@...linear.com>, "john@...ozen.org"
	<john@...ozen.org>, "davem@...emloft.net" <davem@...emloft.net>,
	"yweng@...linear.com" <yweng@...linear.com>, "bxu@...linear.com"
	<bxu@...linear.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "fchan@...linear.com" <fchan@...linear.com>,
	"ajayaraman@...linear.com" <ajayaraman@...linear.com>, "hauke@...ke-m.de"
	<hauke@...ke-m.de>, "kuba@...nel.org" <kuba@...nel.org>,
	"jpovazanec@...linear.com" <jpovazanec@...linear.com>, "Stockmann, Lukas"
	<lukas.stockmann@...mens.com>
Subject: Re: [PATCH net-next v4 0/7] net: dsa: lantiq_gswip: use regmap for
 register access

Hi Daniel,

On Mon, 2025-10-20 at 13:57 +0100, Daniel Golle wrote:
> This series refactors the lantiq_gswip driver to utilize the regmap API
> for register access, replacing the previous approach of open-coding
> register operations.
> 
> Using regmap paves the way for supporting different busses to access the
> switch registers, for example it makes it easier to use an MDIO-based
> method required to access the registers of the MaxLinear GSW1xx series
> of dedicated switch ICs.

thank you for the patches!
I've tested this series with your GSW1xx support patches [1] on top with GSW145
hardware, looks good to me:

Tested-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>

[1] Link: https://github.com/dangowrt/linux/tree/mxl-gsw1xx-for-net-next

> Daniel Golle (7):
>   net: dsa: lantiq_gswip: clarify GSWIP 2.2 VLAN mode in comment
>   net: dsa: lantiq_gswip: convert accessors to use regmap
>   net: dsa: lantiq_gswip: convert trivial accessor uses to regmap
>   net: dsa: lantiq_gswip: manually convert remaining uses of read
>     accessors
>   net: dsa: lantiq_gswip: replace *_mask() functions with regmap API
>   net: dsa: lantiq_gswip: optimize regmap_write_bits() statements
>   net: dsa: lantiq_gswip: harmonize gswip_mii_mask_*() parameters
> 
>  drivers/net/dsa/lantiq/Kconfig        |   1 +
>  drivers/net/dsa/lantiq/lantiq_gswip.c | 471 +++++++++++++-------------
>  drivers/net/dsa/lantiq/lantiq_gswip.h |   6 +-
>  3 files changed, 243 insertions(+), 235 deletions(-)
> 

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com