netdev - Re: [PATCH net-next] net: bonding: use workqueue to make sure peer notify updated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPdswnBumIsSq8fY@horms.kernel.org>
Date: Tue, 21 Oct 2025 12:21:38 +0100
From: Simon Horman <horms@...nel.org>
To: Tonghao Zhang <tonghao@...aicloud.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <jv@...sburgh.net>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCH net-next] net: bonding: use workqueue to make sure peer
 notify updated

On Tue, Oct 21, 2025 at 01:22:49PM +0800, Tonghao Zhang wrote:
> The RTNL might be locked, preventing ad_cond_set_peer_notif from acquiring
> the lock and updating send_peer_notif. This patch addresses the issue by
> using a workqueue. Since updating send_peer_notif does not require high
> real-time performance, such delayed updates are entirely acceptable.
> 
> Cc: Jay Vosburgh <jv@...sburgh.net>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Simon Horman <horms@...nel.org>
> Cc: Jonathan Corbet <corbet@....net>
> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> Cc: Nikolay Aleksandrov <razor@...ckwall.org>
> Cc: Hangbin Liu <liuhangbin@...il.com>
> Suggested-by: Hangbin Liu <liuhangbin@...il.com>
> Signed-off-by: Tonghao Zhang <tonghao@...aicloud.com>
> ---
>  drivers/net/bonding/bond_3ad.c  |  7 ++-----
>  drivers/net/bonding/bond_main.c | 27 +++++++++++++++++++++++++++
>  include/net/bonding.h           |  2 ++
>  3 files changed, 31 insertions(+), 5 deletions(-)

This is not a proper review. So please wait, say a day, for one.

But this patch does not apply cleanly to net-next,
and thus will need to be rebased and reposted.

-- 
pw-bot: cr