netdev - Re: [PATCH] ptp: ocp: Fix typo using index 1 instead of i in SMA initialization loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <951141f8-f26b-4d0e-bf54-5c7f4e0b99af@linux.dev>
Date: Tue, 21 Oct 2025 20:47:43 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Jiasheng Jiang <jiashengjiangcool@...il.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>
Cc: Richard Cochran <richardcochran@...il.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
 Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ptp: ocp: Fix typo using index 1 instead of i in SMA
 initialization loop

On 21/10/2025 19:24, Jiasheng Jiang wrote:
> In ptp_ocp_sma_fb_init(), the code mistakenly used bp->sma[1]
> instead of bp->sma[i] inside a for-loop, which caused only SMA[1]
> to have its DIRECTION_CAN_CHANGE capability cleared. This led to
> inconsistent capability flags across SMA pins.
> 
> Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...il.com>
> ---
>   drivers/ptp/ptp_ocp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 794ec6e71990..a5c363252986 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -2548,7 +2548,7 @@ ptp_ocp_sma_fb_init(struct ptp_ocp *bp)
>   		for (i = 0; i < OCP_SMA_NUM; i++) {
>   			bp->sma[i].fixed_fcn = true;
>   			bp->sma[i].fixed_dir = true;
> -			bp->sma[1].dpll_prop.capabilities &=
> +			bp->sma[i].dpll_prop.capabilities &=
>   				~DPLL_PIN_CAPABILITIES_DIRECTION_CAN_CHANGE;
>   		}
>   		return;

Thanks!

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>