netdev - Re: [PATCH v1 6.14] wireless: aic8800: add support for AIC8800 WiFi chipset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01030786-764c-4215-a4ca-dcd841e6ed3e@kernel.org>
Date: Tue, 21 Oct 2025 09:03:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "he.zhenang" <he.zhenang@...mex.com>, johannes@...solutions.net
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v1 6.14] wireless: aic8800: add support for AIC8800 WiFi
 chipset

On 20/10/2025 11:21, he.zhenang wrote:
> Add driver support for the AIC8800 WiFi chipset family.
> 
> Driver features:
> - Supports 802.11ax (Wi-Fi 6) and backward compatible modes
> - PCIe/USB/SDIO interface support
> - Hardware encryption offload (WPA3 support)
> - Enhanced power management for mobile devices
> - Integrated Bluetooth coexistence (if applicable)
> 
v6.14? That's ancient. Work on mainline, please.

Also, this is absolutely unmanageable huge patch. Please read submitting
patches document.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof