netdev - Re: [PATCH net-next v02 2/6] hinic3: Add PF management interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2534ab3-a843-43db-9447-19954467e2ed@redhat.com>
Date: Tue, 21 Oct 2025 11:25:00 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Fan Gong <gongfan1@...wei.com>, Zhu Yikai <zhuyikai1@...artners.com>,
 netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Simon Horman <horms@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 Markus.Elfring@....de, pavan.chebbi@...adcom.com
Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 luosifu <luosifu@...wei.com>, Xin Guo <guoxin09@...wei.com>,
 Shen Chenyang <shenchenyang1@...ilicon.com>,
 Zhou Shuai <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>,
 Shi Jing <shijing34@...wei.com>, Luo Yang <luoyang82@...artners.com>,
 Meny Yossefi <meny.yossefi@...wei.com>, Gur Stavi <gur.stavi@...wei.com>
Subject: Re: [PATCH net-next v02 2/6] hinic3: Add PF management interfaces

On 10/17/25 10:30 AM, Fan Gong wrote:
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h b/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h
> index 78cface6ddd7..58c0c0b55097 100644
> --- a/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h
> @@ -39,24 +39,25 @@ struct hinic3_pcidev {
>  };
>  
>  struct hinic3_hwdev {
> -	struct hinic3_pcidev        *adapter;
> -	struct pci_dev              *pdev;
> -	struct device               *dev;
> -	int                         dev_id;
> -	struct hinic3_hwif          *hwif;
> -	struct hinic3_cfg_mgmt_info *cfg_mgmt;
> -	struct hinic3_aeqs          *aeqs;
> -	struct hinic3_ceqs          *ceqs;
> -	struct hinic3_mbox          *mbox;
> -	struct hinic3_cmdqs         *cmdqs;
> -	struct delayed_work         sync_time_task;
> -	struct workqueue_struct     *workq;
> -	/* protect channel init and uninit */
> -	spinlock_t                  channel_lock;
> -	u64                         features[COMM_MAX_FEATURE_QWORD];
> -	u32                         wq_page_size;
> -	u8                          max_cmdq;
> -	ulong                       func_state;
> +	struct hinic3_pcidev         *adapter;
> +	struct pci_dev               *pdev;
> +	struct device                *dev;
> +	int                          dev_id;
> +	struct hinic3_hwif           *hwif;
> +	struct hinic3_cfg_mgmt_info  *cfg_mgmt;
> +	struct hinic3_aeqs           *aeqs;
> +	struct hinic3_ceqs           *ceqs;
> +	struct hinic3_mbox           *mbox;
> +	struct hinic3_msg_pf_to_mgmt *pf_to_mgmt;
> +	struct hinic3_cmdqs          *cmdqs;
> +	struct delayed_work          sync_time_task;
> +	struct workqueue_struct      *workq;
> +	/* protect hwdev channel init and uninit */
> +	spinlock_t                   channel_lock;
> +	u64                          features[COMM_MAX_FEATURE_QWORD];
> +	u32                          wq_page_size;
> +	u8                           max_cmdq;
> +	ulong                        func_state;

The above is a nice way to hide a single line addition. Please either
avoid the reformatting entirely (preferred) or do the re-indentation in
a separate pre-req patch.

/P