netdev - Re: [PATCH net-next v3 02/15] net: Implement netdev_nl_bind_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90057a08-2df1-413f-9be1-e1a2755ada4e@iogearbox.net>
Date: Wed, 22 Oct 2025 13:26:07 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Nikolay Aleksandrov <razor@...ckwall.org>, netdev@...r.kernel.org
Cc: bpf@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
 pabeni@...hat.com, willemb@...gle.com, sdf@...ichev.me,
 john.fastabend@...il.com, martin.lau@...nel.org, jordan@...fe.io,
 maciej.fijalkowski@...el.com, magnus.karlsson@...el.com, dw@...idwei.uk,
 toke@...hat.com, yangzhenze@...edance.com, wangdongdong.6@...edance.com
Subject: Re: [PATCH net-next v3 02/15] net: Implement
 netdev_nl_bind_queue_doit

On 10/22/25 1:17 PM, Nikolay Aleksandrov wrote:
> On 10/20/25 19:23, Daniel Borkmann wrote:
[...]
>> +		goto err_unlock_src_dev;
>> +	}
>> +
>> +	err = dst_dev->queue_mgmt_ops->ndo_queue_create(dst_dev);
>> +	if (err <= 0) {
> 
> <= 0 is a bit weird, if 0 signals an error perhaps "err" must be set?
> 
> Maybe directly use dst_qid above and set "err" appropriately to better
> demonstrate what's expected?
Ok, yeah makes sense, we can pass the queue id as a param which the
ndo callback needs to fill out on success and then the return is either
error or no error. Seems simpler, will address in v4 then.

Thanks,
Daniel