netdev - Re: [PATCH net-next 1/4] net: phy: add iterator phy_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251021182451.33de59e8@kernel.org>
Date: Tue, 21 Oct 2025 18:24:51 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>, Clark
 Wang <xiaoning.wang@....com>, Siddharth Vadapalli <s-vadapalli@...com>,
 Roger Quadros <rogerq@...nel.org>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, imx@...ts.linux.dev, linux-omap@...r.kernel.org,
 Andrew Lunn <andrew@...n.ch>, Andrew Lunn <andrew+netdev@...n.ch>, Russell
 King - ARM Linux <linux@...linux.org.uk>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next 1/4] net: phy: add iterator phy_for_each

On Fri, 17 Oct 2025 22:41:12 +0200 Heiner Kallweit wrote:
> +#define phy_for_each(_bus, _phydev)			\
> +	for (_phydev = phy_find_first(_bus); _phydev;	\
> +	     _phydev = phy_find_next(_bus, _phydev))

Wouldn't this better be called mii_for_each_phy() or
mii_bus_for_each_phy() ?

To an outsider and with PHY typologies it may not be
sufficiently obvious that this helper is used to iterate
a all addresses on a MII bus.