netdev - Re: [PATCH net-next] igbvf: fix misplaced newline in VLAN add warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPjurC9zjCBX1A_P@horms.kernel.org>
Date: Wed, 22 Oct 2025 15:48:12 +0100
From: Simon Horman <horms@...nel.org>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com,
	andrew+netdev@...n.ch, kuba@...nel.org, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	alok.a.tiwarilinux@...il.com
Subject: Re: [PATCH net-next] igbvf: fix misplaced newline in VLAN add
 warning message

On Tue, Oct 21, 2025 at 12:32:01PM -0700, Alok Tiwari wrote:
> Corrected the dev_warn format string:
> - "Vlan id %d\n is not added" -> "Vlan id %d is not added\n"
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Interesting, there seem to be some other cases of this, at least under
net/divers. Do you plan to address those too?

In any case, looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>