netdev - Re: [PATCH net-next 0/3] icmp: Add RFC 5837 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <410cd787-0085-4409-97c1-2019a7baab8b@kernel.org>
Date: Wed, 22 Oct 2025 11:29:20 -0600
From: David Ahern <dsahern@...nel.org>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, horms@...nel.org, petrm@...dia.com, willemb@...gle.com,
 daniel@...earbox.net, fw@...len.de, ishaangandhi@...il.com,
 rbonica@...iper.net, tom@...bertland.com
Subject: Re: [PATCH net-next 0/3] icmp: Add RFC 5837 support

On 10/22/25 12:53 AM, Ido Schimmel wrote:
> Testing
> =======
> 
> The existing traceroute selftest is extended to test that ICMP
> extensions are reported correctly when enabled. Both address families
> are tested and with different packet sizes in order to make sure that
> trimming / padding works correctly.
> 

For the set:
Reviewed-by: David Ahern <dsahern@...nel.org>

Did you try testing this with an older kernel versions on the receiving
side of the icmp packet? ie., making sure older code does not have a bad
reaction to the extra data in the icmp.