netdev - Re: [RFC 00/15] net/rds: RDS-TCP bug fix collection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f725c08246638a1a840d01d2aa0fed7847de5c6.camel@oracle.com>
Date: Wed, 22 Oct 2025 22:04:15 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "achender@...nel.org" <achender@...nel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: Re: [RFC 00/15] net/rds: RDS-TCP bug fix collection

Oops, this series should be "RFC next-next". 

Apologies for the confusion!
Allison

On Wed, 2025-10-22 at 12:17 -0700, Allison Henderson wrote:
> From: Allison Henderson <allison.henderson@...cle.com>
> 
> Hi all,
> 
> This set is a collection of  bug-fixes we've been working on for RDS.
> 
> This series was last seen in April, but further testing turned up
> additional bugs that we thought best to address as part of the same
> effort. So the series has grown a bit, and I’ve restarted versioning
> since the set sent last spring. Many of the April patches are retained
> here though.
> 
> To refresh: under stress testing, RDS has shown dropped or
> out-of-sequence message issues. These patches address those problems,
> together with a bit of work queue refactoring.
> 
> Since the April posting, patches 2, 3, 6 and 10–16 are new. To ease
> reviewing, I was thinking we could split the set into smaller logical
> subsets.  Maybe something like this:
> 
> Workqueue scalability (subset 1)
> net/rds: Add per cp work queue
> net/rds: Give each connection its own workqueue
> 
> Bug fixes (subset 2)
> net/rds: Change return code from rds_send_xmit() when lock is taken
> net/rds: No shortcut out of RDS_CONN_ERROR
> net/rds: rds_tcp_accept_one ought to not discard messages
> 
> Protocol/extension fixes (subset 3)
> net/rds: new extension header: rdma bytes
> net/rds: Encode cp_index in TCP source port
> net/rds: rds_tcp_conn_path_shutdown must not discard messages
> net/rds: Kick-start TCP receiver after accept
> net/rds: Clear reconnect pending bit
> net/rds: Use the first lane until RDS_EXTHDR_NPATHS arrives
> net/rds: Trigger rds_send_hs_ping() more than once
> 
> Send path and fan-out fixes (subset 4)
> net/rds: Delegate fan-out to a background worker
> net/rds: Use proper peer port number even when not connected
> net/rds: rds_sendmsg should not discard payload_len
> 
> If this breakdown seems useful, we can start with just the first set
> and I'll keep with a branch with the full set available for those who
> want to look ahead.  Otherwise I’ll keep the full set together.  Let me
> know what would be most helpful.
> 
> Questions, comments, flames appreciated!
> Thanks,
> Allison
> 
> 
> Allison Henderson (2):
>   net/rds: Add per cp work queue
>   net/rds: rds_sendmsg should not discard payload_len
> 
> Gerd Rausch (8):
>   net/rds: No shortcut out of RDS_CONN_ERROR
>   net/rds: rds_tcp_accept_one ought to not discard messages
>   net/rds: Encode cp_index in TCP source port
>   net/rds: rds_tcp_conn_path_shutdown must not discard messages
>   net/rds: Kick-start TCP receiver after accept
>   net/rds: Use the first lane until RDS_EXTHDR_NPATHS arrives
>   net/rds: Trigger rds_send_ping() more than once
>   net/rds: Delegate fan-out to a background worker
> 
> Greg Jumper (1):
>   net/rds: Use proper peer port number even when not connected
> 
> Håkon Bugge (3):
>   net/rds: Give each connection its own workqueue
>   net/rds: Change return code from rds_send_xmit() when lock is taken
>   net/rds: Clear reconnect pending bit
> 
> Shamir Rabinovitch (1):
>   net/rds: new extension header: rdma bytes
> 
>  net/rds/connection.c  |  25 ++++-
>  net/rds/ib.c          |   5 +
>  net/rds/ib_recv.c     |   2 +-
>  net/rds/ib_send.c     |  21 +++-
>  net/rds/message.c     |  66 +++++++++---
>  net/rds/rds.h         |  97 +++++++++++------
>  net/rds/recv.c        |  39 ++++++-
>  net/rds/send.c        | 136 +++++++++++++++---------
>  net/rds/stats.c       |   1 +
>  net/rds/tcp.c         |  31 +++---
>  net/rds/tcp.h         |  34 ++++--
>  net/rds/tcp_connect.c |  70 +++++++++++-
>  net/rds/tcp_listen.c  | 240 +++++++++++++++++++++++++++++++++++-------
>  net/rds/tcp_recv.c    |   6 +-
>  net/rds/tcp_send.c    |   4 +-
>  net/rds/threads.c     |  17 +--
>  16 files changed, 618 insertions(+), 176 deletions(-)
>