netdev - Re: [PATCH net 3/8] idpf: fix possible race in idpf_vport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7c4aa1f-f880-4b9d-96d8-fa54ac6557dd@intel.com>
Date: Wed, 22 Oct 2025 15:49:48 -0700
From: "Tantilov, Emil S" <emil.s.tantilov@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Jacob Keller <jacob.e.keller@...el.com>
CC: Przemek Kitszel <przemyslaw.kitszel@...el.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, "Pavan Kumar
 Linga" <pavan.kumar.linga@...el.com>, Alexander Lobakin
	<aleksander.lobakin@...el.com>, Willem de Bruijn <willemb@...gle.com>,
	Sridhar Samudrala <sridhar.samudrala@...el.com>, Phani Burra
	<phani.r.burra@...el.com>, Piotr Kwapulinski <piotr.kwapulinski@...el.com>,
	Simon Horman <horms@...nel.org>, Radoslaw Tyl <radoslawx.tyl@...el.com>,
	Jedrzej Jagielski <jedrzej.jagielski@...el.com>, Mateusz Polchlopek
	<mateusz.polchlopek@...el.com>, Anton Nadezhdin <anton.nadezhdin@...el.com>,
	Konstantin Ilichev <konstantin.ilichev@...el.com>, Milena Olech
	<milena.olech@...el.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Joshua Hay <joshua.a.hay@...el.com>,
	Aleksandr Loktionov <aleksandr.loktionov@...el.com>, Chittim Madhu
	<madhu.chittim@...el.com>, Samuel Salin <Samuel.salin@...el.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>
Subject: Re: [PATCH net 3/8] idpf: fix possible race in idpf_vport_stop()

On 10/13/2025 11:13 AM, Jakub Kicinski wrote:
> On Wed, 8 Oct 2025 14:41:40 -0700 Jacob Keller wrote:
>> Jakub, from this thread it still seems like you won't accept this patch
>> as-is?
> 
> I haven't analyzed Emil's response. I hope my concern is clear enough
> (at least to you). If the code is provably safe I think the patch itself
> can go in, we just need a much better commit msg.

Actually we can drop this patch as the issue it is fixing is no longer 
reproducible, following the introduction of the RTNL parameter to 
idpf_vport_stop() by Olek:
https://lore.kernel.org/netdev/20250908195748.1707057-5-anthony.l.nguyen@intel.com/

I would still like to keep the first patch in this series:
https://lore.kernel.org/netdev/20250822035248.22969-2-emil.s.tantilov@intel.com/

I will rebase it and resend for -next unless there are objections.

Thanks,
Emil