netdev - Re: [PATCH] net: alteon: migrate to dma_map_phys instead of map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89daafd3-5234-4a61-8b4b-044e6e2d0c3e@intel.com>
Date: Wed, 22 Oct 2025 16:52:25 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Chu Guangqing <chuguangqing@...pur.com>, <jes@...ined-monkey.org>,
	<andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.xn--org-o16s>, <pabeni@...hat.com>
CC: <linux-acenic@...site.dk>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: alteon: migrate to dma_map_phys instead of map_page

On 10/20/2025 7:09 PM, Chu Guangqing wrote:
> After introduction of dma_map_phys(), there is no need to convert
> from physical address to struct page in order to map page. So let's
> use it directly.
> 
> Signed-off-by: Chu Guangqing <chuguangqing@...pur.com>
> ---

Subject should include the tree tag to help automation when determining
where to apply the patch. Since this isn't a fix, this should target the
next tree with [PATCH net-next]. In the future try to remember to
include the tree in your tags for the subject.

The change itself looks reasonable. This converts the chain of
virt_to_page and offset_in_page of the driver followed by page_to_phys
in the core dma_map_page code into just virt_to_phys in the driver.
Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)