netdev - Re: [PATCH net-next 4/5] net/mlx5e: Add PSP stats support for Rx/Tx flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251022175602.560ad464@kernel.org>
Date: Wed, 22 Oct 2025 17:56:02 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Zahka <daniel.zahka@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Saeed Mahameed
 <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, Tariq Toukan
 <tariqt@...dia.com>, Shuah Khan <shuah@...nel.org>, Simon Horman
 <horms@...nel.org>, Donald Hunter <donald.hunter@...il.com>, Boris Pismenny
 <borisp@...dia.com>, Mark Bloch <mbloch@...dia.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, Willem de Bruijn <willemb@...gle.com>, Rahul
 Rameshbabu <rrameshbabu@...dia.com>, Cosmin Ratiu <cratiu@...dia.com>, Raed
 Salem <raeds@...dia.com>, Kuniyuki Iwashima <kuniyu@...gle.com>,
 netdev@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 4/5] net/mlx5e: Add PSP stats support for Rx/Tx
 flows

On Wed, 22 Oct 2025 12:37:36 -0700 Daniel Zahka wrote:
> 		mlx5_core_warn(mdev,
> +			       "fail to create psp rx flow counter err(%ld)\n",
> +			       PTR_ERR(flow_counter));
> +		err = PTR_ERR(flow_counter);
> +		goto out_err;
> +	}
> +	accel_psp->rx_counter = flow_counter;
> +
> +	flow_counter = mlx5_fc_create(mdev, false);
> +	if (IS_ERR(flow_counter)) {
> +		mlx5_core_warn(mdev,
> +			       "fail to create psp rx auth fail flow counter err(%ld)\n",
> +			       PTR_ERR(flow_counter));
> +		err = PTR_ERR(flow_counter);
> +		goto out_counter_err;
> +	}
> +	accel_psp->rx_auth_fail_counter = flow_counter;
> +
> +	flow_counter = mlx5_fc_create(mdev, false);
> +	if (IS_ERR(flow_counter)) {
> +		mlx5_core_warn(mdev,
> +			       "fail to create psp rx error flow counter err(%ld)\n",
> +			       PTR_ERR(flow_counter));
> +		err = PTR_ERR(flow_counter);
> +		goto out_auth_fail_counter_err;
> +	}
> +	accel_psp->rx_err_counter = flow_counter;
> +
> +	flow_counter = mlx5_fc_create(mdev, false);
> +	if (IS_ERR(flow_counter)) {
> +		mlx5_core_warn(mdev,
> +			       "fail to create psp rx auth fail flow counter err(%ld)\n",
> +			       PTR_ERR(flow_counter));

Coccicheck sayeth (5x):

drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c:
WARNING: Consider using %pe to print PTR_ERR()

That's %pe, flow_counter instead of %d, PTR_ERR(flow_counter)
-- 
pw-bot: cr