netdev - Re: [PATCH] udp: Move back definition of udpv6_encap_needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d649240da086bad2abd1367e20a611f273bbdfb.camel@oracle.com>
Date: Thu, 23 Oct 2025 10:24:02 +0000
From: Siddh Raman Pant <siddh.raman.pant@...cle.com>
To: "sd@...asysnail.net" <sd@...asysnail.net>
CC: "willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] udp: Move back definition of udpv6_encap_needed_key to
 ipv6 file.

On Thu, Oct 23 2025 at 15:47:37 +0530, Sabrina Dubroca wrote:
> 2025-10-23, 14:37:36 +0530, Siddh Raman Pant wrote:
> > It makes less sense to remove define of ipv6 variable from ipv6 file
> > and put it in ipv4 file and declare it in ipv6 file, which was done
> > in 3d010c8031e3 ("udp: do not accept non-tunnel GSO skbs landing in
> > a tunnel").
> 
> It would be good to CC all the authors and reviewers of the patch(es)
> you're mentioning.
> 
> > So let's move it back to ipv6 file. It also makes the code similar -
> > the key is defined right above the respective enable function.
> 
> I don't think that works with CONFIG_IPV6=m. The ipv4 code will need
> to access the key via udp_encap_needed().
> 
> 
> > Signed-off-by: Siddh Raman Pant <siddh.raman.pant@...cle.com>
> > ---
> > I'm not sure why ipv4 key is exported using EXPORT_IPV6_MOD?
> 
> So that the ipv6 code can use it via
> udp_encap_needed()/udp_unexpected_gso() when it's built as a module.

Cool, thank you very much for the explanation! That was what I was
missing.

Please ignore this patch then.

Thanks,
Siddh

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)