netdev - Re: [PATCH iproute2] devlink: fix devlink flash error reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m36eg2tmmnqnu7yznbn5jdlqxsxxgwknv2vnc4bpfc36q6zopw@macasn5cvvrh>
Date: Thu, 23 Oct 2025 14:06:19 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Ivan Vecera <ivecera@...hat.com>
Cc: netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2] devlink: fix devlink flash error reporting

Wed, Oct 22, 2025 at 02:23:02PM +0200, ivecera@...hat.com wrote:
>Currently, devlink silently exits when a non-existent device is specified
>for flashing or when the user lacks sufficient permissions. This makes it
>hard to diagnose the problem.
>
>Print an appropriate error message in these cases to improve user feedback.
>
>Prior:
>$ devlink dev flash foo/bar file test
>$ sudo devlink dev flash foo/bar file test
>$
>
>After patch:
>$ devlink/devlink dev flash foo/bar file test
>devlink answers: Operation not permitted
>$ sudo devlink/devlink dev flash foo/bar file test
>devlink answers: No such device
>
>Fixes: 9b13cddfe268 ("devlink: implement flash status monitoring")
>Signed-off-by: Ivan Vecera <ivecera@...hat.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>

Thanks!