netdev - Re: [PATCH net] net: vlan: sync VLAN features with lower device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251023065517.2d3dfca0@kernel.org>
Date: Thu, 23 Oct 2025 06:55:17 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Simon
 Horman <horms@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, "Dr. David
 Alan Gilbert" <linux@...blig.org>, Dong Chenchen
 <dongchenchen2@...wei.com>, Oscar Maes <oscmaes92@...il.com>
Subject: Re: [PATCH net] net: vlan: sync VLAN features with lower device

On Thu, 23 Oct 2025 15:39:07 +0200 Paolo Abeni wrote:
> > @@ -193,6 +193,8 @@ int register_vlan_dev(struct net_device *dev, struct netlink_ext_ack *extack)
> >  	vlan_group_set_device(grp, vlan->vlan_proto, vlan_id, dev);
> >  	grp->nr_vlan_devs++;
> >  
> > +	netdev_change_features(dev);  
> 
> Is this just for NETIF_F_LRO? it feels a bit overkill for single flag.
> Also, why netdev_change_features() (vs netdev_update_features())?

Another thought -- isn't this a problem for more uppers?
Isn't this what all callers of netdev_upper_dev_link() effectively
need, and therefore perhaps we should stick it somewhere in the core
(netdev_upper_dev_link() itself or when device is registered) ?